diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-04-15 17:42:36 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-04-15 17:42:36 +0100 |
| commit | 3af303600afdc4282dde3a1c8b6c0810662a3e63 (patch) | |
| tree | 2ecf0422de2258515ad0d373320eb7df44857187 /crates/hir_def/src/dyn_map.rs | |
| parent | 8d17d0c58cbe7006c656aced985552f51e1bd675 (diff) | |
| parent | 30aae2cefb9d068055ca8d250d04a288e3684394 (diff) | |
| parent | 6e575d8c73fa93e2300c3c61343d7efa7f20b7bf (diff) | |
Merge #8510 #8533
8510: Move cursor position when using item movers r=jonas-schievink a=jonas-schievink
This updates the cursor position when moving items around to stay in the same location within the moved node.
I changed the `moveItem` response to `SnippetTextEdit[]`, since that made more sense to me (the file was ignored by the client anyways, since the edits always apply to the current document). It also matches `onEnter`, which seems logical to me, but please let me know if this doesn't make sense.
There's still a bug in the client-side snippet code that will cause the cursor position to be slightly off when moving parameters in the same line (presumably we don't track the column correctly after deleting `$0`). Not really sure how to fix that immediately, but this PR should already be an improvement despite that bug.
8533: Fix typo in style guide r=jonas-schievink a=jonas-schievink
Fixes bold text rendering
bors r+
Co-authored-by: Jonas Schievink <[email protected]>