diff options
author | Jonas Schievink <[email protected]> | 2020-12-01 11:40:03 +0000 |
---|---|---|
committer | Jonas Schievink <[email protected]> | 2020-12-01 11:40:03 +0000 |
commit | ea7b81fef990e281b4b958cff7357544076d4b15 (patch) | |
tree | 248fe495ac74a7b0e759c0890da17d6851fe3e6f /crates/hir_def | |
parent | be50908a5031fee45fcbba97bc0c96187324ea54 (diff) |
Emit unresolved proc macro errors
Diffstat (limited to 'crates/hir_def')
-rw-r--r-- | crates/hir_def/src/body/diagnostics.rs | 6 | ||||
-rw-r--r-- | crates/hir_def/src/body/lower.rs | 31 |
2 files changed, 28 insertions, 9 deletions
diff --git a/crates/hir_def/src/body/diagnostics.rs b/crates/hir_def/src/body/diagnostics.rs index 144c61b17..1de7d30e2 100644 --- a/crates/hir_def/src/body/diagnostics.rs +++ b/crates/hir_def/src/body/diagnostics.rs | |||
@@ -2,12 +2,13 @@ | |||
2 | 2 | ||
3 | use hir_expand::diagnostics::DiagnosticSink; | 3 | use hir_expand::diagnostics::DiagnosticSink; |
4 | 4 | ||
5 | use crate::diagnostics::{InactiveCode, MacroError}; | 5 | use crate::diagnostics::{InactiveCode, MacroError, UnresolvedProcMacro}; |
6 | 6 | ||
7 | #[derive(Debug, Eq, PartialEq)] | 7 | #[derive(Debug, Eq, PartialEq)] |
8 | pub(crate) enum BodyDiagnostic { | 8 | pub(crate) enum BodyDiagnostic { |
9 | InactiveCode(InactiveCode), | 9 | InactiveCode(InactiveCode), |
10 | MacroError(MacroError), | 10 | MacroError(MacroError), |
11 | UnresolvedProcMacro(UnresolvedProcMacro), | ||
11 | } | 12 | } |
12 | 13 | ||
13 | impl BodyDiagnostic { | 14 | impl BodyDiagnostic { |
@@ -19,6 +20,9 @@ impl BodyDiagnostic { | |||
19 | BodyDiagnostic::MacroError(diag) => { | 20 | BodyDiagnostic::MacroError(diag) => { |
20 | sink.push(diag.clone()); | 21 | sink.push(diag.clone()); |
21 | } | 22 | } |
23 | BodyDiagnostic::UnresolvedProcMacro(diag) => { | ||
24 | sink.push(diag.clone()); | ||
25 | } | ||
22 | } | 26 | } |
23 | } | 27 | } |
24 | } | 28 | } |
diff --git a/crates/hir_def/src/body/lower.rs b/crates/hir_def/src/body/lower.rs index c0617c1a1..2c41c0005 100644 --- a/crates/hir_def/src/body/lower.rs +++ b/crates/hir_def/src/body/lower.rs | |||
@@ -8,7 +8,7 @@ use either::Either; | |||
8 | use hir_expand::{ | 8 | use hir_expand::{ |
9 | hygiene::Hygiene, | 9 | hygiene::Hygiene, |
10 | name::{name, AsName, Name}, | 10 | name::{name, AsName, Name}, |
11 | HirFileId, MacroDefId, MacroDefKind, | 11 | ExpandError, HirFileId, MacroDefId, MacroDefKind, |
12 | }; | 12 | }; |
13 | use rustc_hash::FxHashMap; | 13 | use rustc_hash::FxHashMap; |
14 | use syntax::{ | 14 | use syntax::{ |
@@ -25,7 +25,7 @@ use crate::{ | |||
25 | body::{Body, BodySourceMap, Expander, PatPtr, SyntheticSyntax}, | 25 | body::{Body, BodySourceMap, Expander, PatPtr, SyntheticSyntax}, |
26 | builtin_type::{BuiltinFloat, BuiltinInt}, | 26 | builtin_type::{BuiltinFloat, BuiltinInt}, |
27 | db::DefDatabase, | 27 | db::DefDatabase, |
28 | diagnostics::{InactiveCode, MacroError}, | 28 | diagnostics::{InactiveCode, MacroError, UnresolvedProcMacro}, |
29 | expr::{ | 29 | expr::{ |
30 | dummy_expr_id, ArithOp, Array, BinaryOp, BindingAnnotation, CmpOp, Expr, ExprId, Literal, | 30 | dummy_expr_id, ArithOp, Array, BinaryOp, BindingAnnotation, CmpOp, Expr, ExprId, Literal, |
31 | LogicOp, MatchArm, Ordering, Pat, PatId, RecordFieldPat, RecordLitField, Statement, | 31 | LogicOp, MatchArm, Ordering, Pat, PatId, RecordFieldPat, RecordLitField, Statement, |
@@ -563,12 +563,27 @@ impl ExprCollector<'_> { | |||
563 | let macro_call = self.expander.to_source(AstPtr::new(&e)); | 563 | let macro_call = self.expander.to_source(AstPtr::new(&e)); |
564 | let res = self.expander.enter_expand(self.db, Some(&self.body.item_scope), e); | 564 | let res = self.expander.enter_expand(self.db, Some(&self.body.item_scope), e); |
565 | 565 | ||
566 | if let Some(err) = res.err { | 566 | match res.err { |
567 | self.source_map.diagnostics.push(BodyDiagnostic::MacroError(MacroError { | 567 | Some(ExpandError::UnresolvedProcMacro) => { |
568 | file: self.expander.current_file_id, | 568 | self.source_map.diagnostics.push(BodyDiagnostic::UnresolvedProcMacro( |
569 | node: syntax_ptr.clone().into(), | 569 | UnresolvedProcMacro { |
570 | message: err.to_string(), | 570 | file: self.expander.current_file_id, |
571 | })); | 571 | node: syntax_ptr.clone().into(), |
572 | precise_location: None, | ||
573 | macro_name: None, | ||
574 | }, | ||
575 | )); | ||
576 | } | ||
577 | Some(err) => { | ||
578 | self.source_map.diagnostics.push(BodyDiagnostic::MacroError( | ||
579 | MacroError { | ||
580 | file: self.expander.current_file_id, | ||
581 | node: syntax_ptr.clone().into(), | ||
582 | message: err.to_string(), | ||
583 | }, | ||
584 | )); | ||
585 | } | ||
586 | None => {} | ||
572 | } | 587 | } |
573 | 588 | ||
574 | match res.value { | 589 | match res.value { |