diff options
author | Jonas Schievink <[email protected]> | 2020-12-15 14:37:37 +0000 |
---|---|---|
committer | Jonas Schievink <[email protected]> | 2020-12-15 14:37:37 +0000 |
commit | c1cb5953820f26d4d0a614650bc8c50cbc5a3ce6 (patch) | |
tree | 01ba67d97ce6f261154df59b268fe924af9add2a /crates/hir_expand | |
parent | 39aae835fd70d06092c1be1add6eef3984439529 (diff) |
Move to upstream `macro_rules!` model
Diffstat (limited to 'crates/hir_expand')
-rw-r--r-- | crates/hir_expand/src/builtin_macro.rs | 16 | ||||
-rw-r--r-- | crates/hir_expand/src/lib.rs | 2 |
2 files changed, 11 insertions, 7 deletions
diff --git a/crates/hir_expand/src/builtin_macro.rs b/crates/hir_expand/src/builtin_macro.rs index b1b432ded..bd9223825 100644 --- a/crates/hir_expand/src/builtin_macro.rs +++ b/crates/hir_expand/src/builtin_macro.rs | |||
@@ -63,7 +63,7 @@ macro_rules! register_builtin { | |||
63 | pub fn find_builtin_macro( | 63 | pub fn find_builtin_macro( |
64 | ident: &name::Name, | 64 | ident: &name::Name, |
65 | krate: CrateId, | 65 | krate: CrateId, |
66 | ast_id: AstId<ast::MacroCall>, | 66 | ast_id: AstId<ast::MacroRules>, |
67 | ) -> Option<MacroDefId> { | 67 | ) -> Option<MacroDefId> { |
68 | let kind = find_by_name(ident)?; | 68 | let kind = find_by_name(ident)?; |
69 | 69 | ||
@@ -515,12 +515,16 @@ mod tests { | |||
515 | fn expand_builtin_macro(ra_fixture: &str) -> String { | 515 | fn expand_builtin_macro(ra_fixture: &str) -> String { |
516 | let (db, file_id) = TestDB::with_single_file(&ra_fixture); | 516 | let (db, file_id) = TestDB::with_single_file(&ra_fixture); |
517 | let parsed = db.parse(file_id); | 517 | let parsed = db.parse(file_id); |
518 | let macro_rules: Vec<_> = | ||
519 | parsed.syntax_node().descendants().filter_map(ast::MacroRules::cast).collect(); | ||
518 | let macro_calls: Vec<_> = | 520 | let macro_calls: Vec<_> = |
519 | parsed.syntax_node().descendants().filter_map(ast::MacroCall::cast).collect(); | 521 | parsed.syntax_node().descendants().filter_map(ast::MacroCall::cast).collect(); |
520 | 522 | ||
521 | let ast_id_map = db.ast_id_map(file_id.into()); | 523 | let ast_id_map = db.ast_id_map(file_id.into()); |
522 | 524 | ||
523 | let expander = find_by_name(¯o_calls[0].name().unwrap().as_name()).unwrap(); | 525 | assert_eq!(macro_rules.len(), 1, "test must contain exactly 1 `macro_rules!`"); |
526 | assert_eq!(macro_calls.len(), 1, "test must contain exactly 1 macro call"); | ||
527 | let expander = find_by_name(¯o_rules[0].name().unwrap().as_name()).unwrap(); | ||
524 | 528 | ||
525 | let krate = CrateId(0); | 529 | let krate = CrateId(0); |
526 | let file_id = match expander { | 530 | let file_id = match expander { |
@@ -528,7 +532,7 @@ mod tests { | |||
528 | // the first one should be a macro_rules | 532 | // the first one should be a macro_rules |
529 | let def = MacroDefId { | 533 | let def = MacroDefId { |
530 | krate: Some(CrateId(0)), | 534 | krate: Some(CrateId(0)), |
531 | ast_id: Some(AstId::new(file_id.into(), ast_id_map.ast_id(¯o_calls[0]))), | 535 | ast_id: Some(AstId::new(file_id.into(), ast_id_map.ast_id(¯o_rules[0]))), |
532 | kind: MacroDefKind::BuiltIn(expander), | 536 | kind: MacroDefKind::BuiltIn(expander), |
533 | local_inner: false, | 537 | local_inner: false, |
534 | }; | 538 | }; |
@@ -538,7 +542,7 @@ mod tests { | |||
538 | krate, | 542 | krate, |
539 | kind: MacroCallKind::FnLike(AstId::new( | 543 | kind: MacroCallKind::FnLike(AstId::new( |
540 | file_id.into(), | 544 | file_id.into(), |
541 | ast_id_map.ast_id(¯o_calls[1]), | 545 | ast_id_map.ast_id(¯o_calls[0]), |
542 | )), | 546 | )), |
543 | }; | 547 | }; |
544 | 548 | ||
@@ -549,12 +553,12 @@ mod tests { | |||
549 | // the first one should be a macro_rules | 553 | // the first one should be a macro_rules |
550 | let def = MacroDefId { | 554 | let def = MacroDefId { |
551 | krate: Some(krate), | 555 | krate: Some(krate), |
552 | ast_id: Some(AstId::new(file_id.into(), ast_id_map.ast_id(¯o_calls[0]))), | 556 | ast_id: Some(AstId::new(file_id.into(), ast_id_map.ast_id(¯o_rules[0]))), |
553 | kind: MacroDefKind::BuiltInEager(expander), | 557 | kind: MacroDefKind::BuiltInEager(expander), |
554 | local_inner: false, | 558 | local_inner: false, |
555 | }; | 559 | }; |
556 | 560 | ||
557 | let args = macro_calls[1].token_tree().unwrap(); | 561 | let args = macro_calls[0].token_tree().unwrap(); |
558 | let parsed_args = mbe::ast_to_token_tree(&args).unwrap().0; | 562 | let parsed_args = mbe::ast_to_token_tree(&args).unwrap().0; |
559 | 563 | ||
560 | let arg_id = db.intern_eager_expansion({ | 564 | let arg_id = db.intern_eager_expansion({ |
diff --git a/crates/hir_expand/src/lib.rs b/crates/hir_expand/src/lib.rs index 1a9428514..ae3086a95 100644 --- a/crates/hir_expand/src/lib.rs +++ b/crates/hir_expand/src/lib.rs | |||
@@ -228,7 +228,7 @@ pub struct MacroDefId { | |||
228 | // (which will probably require touching this code), we can instead use | 228 | // (which will probably require touching this code), we can instead use |
229 | // that (and also remove the hacks for resolving built-in derives). | 229 | // that (and also remove the hacks for resolving built-in derives). |
230 | pub krate: Option<CrateId>, | 230 | pub krate: Option<CrateId>, |
231 | pub ast_id: Option<AstId<ast::MacroCall>>, | 231 | pub ast_id: Option<AstId<ast::MacroRules>>, |
232 | pub kind: MacroDefKind, | 232 | pub kind: MacroDefKind, |
233 | 233 | ||
234 | pub local_inner: bool, | 234 | pub local_inner: bool, |