aboutsummaryrefslogtreecommitdiff
path: root/crates/hir_ty/src
diff options
context:
space:
mode:
authorIgor Aleksanov <[email protected]>2020-10-05 17:34:23 +0100
committerIgor Aleksanov <[email protected]>2020-10-12 09:05:00 +0100
commitf2c91fc5a8c22b8ac80f100b2b666f2dc9baa67c (patch)
treed9380ebf0b5b1226e72f6431ea11468e74640a56 /crates/hir_ty/src
parent9ea57cac0e9779ac0749ef568eeb3977fe3adacd (diff)
Apply suggestions from code review
Co-authored-by: Lukas Wirth <[email protected]>
Diffstat (limited to 'crates/hir_ty/src')
-rw-r--r--crates/hir_ty/src/diagnostics/decl_check/str_helpers.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/crates/hir_ty/src/diagnostics/decl_check/str_helpers.rs b/crates/hir_ty/src/diagnostics/decl_check/str_helpers.rs
index 8f70c5e84..c1ab1a675 100644
--- a/crates/hir_ty/src/diagnostics/decl_check/str_helpers.rs
+++ b/crates/hir_ty/src/diagnostics/decl_check/str_helpers.rs
@@ -13,7 +13,7 @@ enum DetectedCase {
13fn detect_case(ident: &str) -> DetectedCase { 13fn detect_case(ident: &str) -> DetectedCase {
14 let trimmed_ident = ident.trim_matches('_'); 14 let trimmed_ident = ident.trim_matches('_');
15 let first_lowercase = 15 let first_lowercase =
16 trimmed_ident.chars().next().map(|chr| chr.is_ascii_lowercase()).unwrap_or(false); 16 trimmed_ident.starts_with(|chr| chr.is_ascii_lowercase());
17 let mut has_lowercase = first_lowercase; 17 let mut has_lowercase = first_lowercase;
18 let mut has_uppercase = false; 18 let mut has_uppercase = false;
19 let mut has_underscore = false; 19 let mut has_underscore = false;
@@ -102,7 +102,7 @@ pub fn to_camel_case(ident: &str) -> Option<String> {
102} 102}
103 103
104/// Converts an identifier to a lower_snake_case form. 104/// Converts an identifier to a lower_snake_case form.
105/// Returns `None` if the string is already is lower_snake_case. 105/// Returns `None` if the string is already in lower_snake_case.
106pub fn to_lower_snake_case(ident: &str) -> Option<String> { 106pub fn to_lower_snake_case(ident: &str) -> Option<String> {
107 // First, assume that it's UPPER_SNAKE_CASE. 107 // First, assume that it's UPPER_SNAKE_CASE.
108 match detect_case(ident) { 108 match detect_case(ident) {