diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-10-03 12:00:30 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-10-03 12:00:30 +0100 |
| commit | e5f252ade72fee4776396122dc91a17ddc185a66 (patch) | |
| tree | a9d154c1920dd03e72d83f016e77eb8b652fbbc4 /crates/ide/src/diagnostics | |
| parent | 03dcf5111ad23700335d25ef02749666bbd08cca (diff) | |
| parent | 3cadba4956bf22759803024b69b6bb67e34da576 (diff) | |
Merge #5997
5997: Better inlay hints in 'for' loops r=popzxc a=popzxc
For #5206 (one part of the fix).
This PR refines the logic of spawning an inlay hints in `for` loops. We only must provide a hint if the following criteria are met:
- User already typed `in` keyword.
- Type of expression is known and it's not unit.
**However:** I don't know why, but I was unable to make `complete_for_hint` test work. Either without or with my changes, I was always getting this test failed because no hint was spawned for the loop variable.
This change works locally, so I would really appreciate an explanation why this test isn't working now and how to fix it.
Co-authored-by: Igor Aleksanov <[email protected]>
Diffstat (limited to 'crates/ide/src/diagnostics')
0 files changed, 0 insertions, 0 deletions