diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-09-15 21:15:04 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-09-15 21:15:04 +0100 |
| commit | 748a8ced609004536b78a24eaa0325d2ff947f44 (patch) | |
| tree | 15ece122198b0db397560be997e1874a051fe075 /crates/ide/src/goto_definition.rs | |
| parent | 37f3b9ca2a0252b93c5900e2104e3e954c383869 (diff) | |
| parent | d2fced1c260d976be9ccbb8b6fcbb59c786238c4 (diff) | |
Merge #6010
6010: Avoid checking all ancestors and fix mis-completion r=jonas-schievink a=oxalica
Refactor the logic of `completion_match` to check deterministic number of ancestors instead of `token.ancestors().find_map()`.
This should fix wrong completions (https://github.com/rust-analyzer/rust-analyzer/pull/5976#issuecomment-692332191) and hopefully make completion to be faster (#6004).
More play and test? @jonas-schievink @hammypants
If this patch works, we can avoid the revert #6005 . :disappointed:
Co-authored-by: oxalica <[email protected]>
Diffstat (limited to 'crates/ide/src/goto_definition.rs')
0 files changed, 0 insertions, 0 deletions