diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-01-03 08:56:17 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-01-03 08:56:17 +0000 |
| commit | 520b8a5a4dde032ba6118efb02801611191acc4e (patch) | |
| tree | 811cd86e5c9a2803bc3d38f19f4ad86e60be1d18 /crates/ide/src/syntax_highlighting/test_data/highlight_injection.html | |
| parent | 3bf4cec79932de0a49338f6b87dc20f85dc3a509 (diff) | |
| parent | 40cd6cdf67dcfad89a80ff3a662bec2dfd983d67 (diff) | |
Merge #7115
7115: Migrate HasSource::source to return Option r=matklad a=nick96
I've made a start on fixing #6913 based on the provided work plan, migrating `HasSource::source` to return an `Option`. The simple cases are migrated but there are a few that I'm unsure exactly how they should be handled:
- Logging the processing of functions in `AnalysisStatsCmd::run`: In verbose mode it includes the path to the module containing the function and the syntax range. I've handled this with an if-let but would it be better to blow up here with `expect`? I'm not 100% on the code paths but if we're processing a function definition then the source should exist.
I've handled `source()` in all code paths as `None` being a valid return value but are there some cases where we should just blow up? Also, all I've done is bubble up the returned `None`s, there may be some places where we can recover and still provide something.
Co-authored-by: Nick Spain <[email protected]>
Co-authored-by: Nick Spain <[email protected]>
Diffstat (limited to 'crates/ide/src/syntax_highlighting/test_data/highlight_injection.html')
0 files changed, 0 insertions, 0 deletions