aboutsummaryrefslogtreecommitdiff
path: root/crates/ide/src/syntax_highlighting
diff options
context:
space:
mode:
authorbors[bot] <26634292+bors[bot]@users.noreply.github.com>2021-02-05 15:31:25 +0000
committerGitHub <[email protected]>2021-02-05 15:31:25 +0000
commit2a75594ee894baad5339ff9708ca70f6f69e0a36 (patch)
treeabd96da79edf04649b41c4ea8eb61e9b01123c47 /crates/ide/src/syntax_highlighting
parent855b00cbe600cad34a14841c37a2ac1f2f3a247e (diff)
parent34d5d77cfa09f4460a0851b5650f441771e7373e (diff)
Merge #7505
7505: Widen Highlights root range to covering element r=Veykril a=Veykril There have been a few issues about/containing spurious syntax highlighting panics, which all seem to come from the `rust_analyzer::handlers::handle_semantic_tokens_range` request, which I believe this to be the cause of as the text range we want to highlight here is currently potentially smaller than that of the covering element, so we might highlight something that is inside the covering element, but outside of the text range we wish to highlight causing the assert to fail. Unfortunately this isn't really easy to test since I have yet to find a reproducible cause(#7504 doesn't work for me cause I can't seem to checkout the given commit). See #7504, #7298, #7299 and #7416, all of those contain an assertion failure in syntax highlighting, but only in the range request. Co-authored-by: Lukas Wirth <[email protected]>
Diffstat (limited to 'crates/ide/src/syntax_highlighting')
0 files changed, 0 insertions, 0 deletions