diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-03-21 09:37:08 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-03-21 09:37:08 +0000 |
| commit | 09412d85fc3137d6ada3b27170e14c287f1a1191 (patch) | |
| tree | ac01ec54df0cebba975c82008482319820ce8757 /crates/ide_assists/src/handlers/qualify_path.rs | |
| parent | 2280f62a40f31d83fd79b62c46dd3d610354d78c (diff) | |
| parent | 56a7d246d59d9429304b82bce2f1e71b632c5737 (diff) | |
Merge #8123
8123: Do not display unqualified assoc item completions r=SomeoneToIgnore a=SomeoneToIgnore
Part of https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/autoimport.20weirdness
Removes all flyimport completions for any unqualified associated type, effectively reverting https://github.com/rust-analyzer/rust-analyzer/pull/8095
I've explained the reasoning in the corresponding FIXME and open to discussions.
As an alternative way, we could add yet another parameter in the method that's used by the `qualify_path` and enable it for the qualify assists only.
Co-authored-by: Kirill Bulatov <[email protected]>
Diffstat (limited to 'crates/ide_assists/src/handlers/qualify_path.rs')
| -rw-r--r-- | crates/ide_assists/src/handlers/qualify_path.rs | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/crates/ide_assists/src/handlers/qualify_path.rs b/crates/ide_assists/src/handlers/qualify_path.rs index e7444f7db..f91770a76 100644 --- a/crates/ide_assists/src/handlers/qualify_path.rs +++ b/crates/ide_assists/src/handlers/qualify_path.rs | |||
| @@ -536,6 +536,7 @@ fn main() { | |||
| 536 | } | 536 | } |
| 537 | 537 | ||
| 538 | #[test] | 538 | #[test] |
| 539 | #[ignore = "FIXME: non-trait assoc items completion is unsupported yet, see FIXME in the import_assets.rs for more details"] | ||
| 539 | fn associated_struct_const_unqualified() { | 540 | fn associated_struct_const_unqualified() { |
| 540 | check_assist( | 541 | check_assist( |
| 541 | qualify_path, | 542 | qualify_path, |