diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-04-14 15:20:13 +0100 |
---|---|---|
committer | GitHub <[email protected]> | 2021-04-14 15:20:13 +0100 |
commit | 678af4106504913ea04672e29f452861d97fae18 (patch) | |
tree | 359cb4c3a3ef739ff9fa4a84987f5354e1bde679 /crates/ide_completion/src/completions | |
parent | 10a243ea55565a0dd1de52f8f802c3e3a7bfef54 (diff) | |
parent | 75a2605361e497cdb6f8c8a4056a6ecd1e35ad68 (diff) |
Merge #8514
8514: Add more profiling spans into type inference r=matklad a=SomeoneToIgnore
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8503
I've added a minimal set of spans to remove `???` and showcase the underlying issue:
<img width="1552" alt="image" src="https://user-images.githubusercontent.com/2690773/114722983-f2181900-9d42-11eb-821d-9e93ded5f81f.png">
`db.trait_solve` reliably produces the same timings for the same input in the same place for me, despite supposedly being cached by Salsa.
In my perception, this is a bit odd, so I've decided to stop at this point and discuss it with people with better knowledge on the topic.
Co-authored-by: Kirill Bulatov <[email protected]>
Diffstat (limited to 'crates/ide_completion/src/completions')
0 files changed, 0 insertions, 0 deletions