diff options
author | Florian Diebold <[email protected]> | 2021-03-20 19:07:36 +0000 |
---|---|---|
committer | Florian Diebold <[email protected]> | 2021-03-21 14:29:03 +0000 |
commit | d8f8b495ad5c9e3676ddf7af53b23bb5b7f2fde0 (patch) | |
tree | 66d68e003d7fa1b311e1b4b99c01de6ea0984372 /crates/ide_completion/src/completions | |
parent | 0623bb4d71725d6b07e8cef5665094581f951fc0 (diff) |
Ignore type bindings in generic_predicates_for_param
This allows us to handle more cases without a query cycle, which
includes certain cases that rustc accepted. That in turn means we avoid
triggering salsa-rs/salsa#257 on valid code (it will still happen if the
user writes an actual cycle).
We actually accept more definitions than rustc now; that's because rustc
only ignores bindings when looking up super traits, whereas we now also
ignore them when looking for predicates to disambiguate associated type
shorthand. We could introduce a separate query for super traits if
necessary, but for now I think this should be fine.
Diffstat (limited to 'crates/ide_completion/src/completions')
0 files changed, 0 insertions, 0 deletions