diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-03-12 08:41:16 +0000 |
---|---|---|
committer | GitHub <[email protected]> | 2021-03-12 08:41:16 +0000 |
commit | c01ef6eabab1fa70d3fdfed9c565fadec9f0a5ed (patch) | |
tree | 37160de8384855fd5fadce3ca4a3de4dacdf98b8 /crates/ide_completion/src/item.rs | |
parent | db6364fecc2b0e9a95d9aaece820a86265b4cb4f (diff) | |
parent | 99c4a41cd1a9f9ef0ee4f067f0069a23123b949a (diff) |
Merge #7974
7974: use references in CompletionItem's builder r=matklad a=yonip23
@matklad
This is a follow up to [this pr](https://github.com/rust-analyzer/rust-analyzer/pull/7973)
Co-authored-by: yonip23 <[email protected]>
Diffstat (limited to 'crates/ide_completion/src/item.rs')
-rw-r--r-- | crates/ide_completion/src/item.rs | 34 |
1 files changed, 17 insertions, 17 deletions
diff --git a/crates/ide_completion/src/item.rs b/crates/ide_completion/src/item.rs index 14afec603..cf1aaa131 100644 --- a/crates/ide_completion/src/item.rs +++ b/crates/ide_completion/src/item.rs | |||
@@ -401,42 +401,42 @@ impl Builder { | |||
401 | import_to_add: self.import_to_add, | 401 | import_to_add: self.import_to_add, |
402 | } | 402 | } |
403 | } | 403 | } |
404 | pub(crate) fn lookup_by(mut self, lookup: impl Into<String>) -> Builder { | 404 | pub(crate) fn lookup_by(&mut self, lookup: impl Into<String>) -> &mut Builder { |
405 | self.lookup = Some(lookup.into()); | 405 | self.lookup = Some(lookup.into()); |
406 | self | 406 | self |
407 | } | 407 | } |
408 | pub(crate) fn label(mut self, label: impl Into<String>) -> Builder { | 408 | pub(crate) fn label(&mut self, label: impl Into<String>) -> &mut Builder { |
409 | self.label = label.into(); | 409 | self.label = label.into(); |
410 | self | 410 | self |
411 | } | 411 | } |
412 | pub(crate) fn insert_text(mut self, insert_text: impl Into<String>) -> Builder { | 412 | pub(crate) fn insert_text(&mut self, insert_text: impl Into<String>) -> &mut Builder { |
413 | self.insert_text = Some(insert_text.into()); | 413 | self.insert_text = Some(insert_text.into()); |
414 | self | 414 | self |
415 | } | 415 | } |
416 | pub(crate) fn insert_snippet( | 416 | pub(crate) fn insert_snippet( |
417 | mut self, | 417 | &mut self, |
418 | _cap: SnippetCap, | 418 | _cap: SnippetCap, |
419 | snippet: impl Into<String>, | 419 | snippet: impl Into<String>, |
420 | ) -> Builder { | 420 | ) -> &mut Builder { |
421 | self.insert_text_format = InsertTextFormat::Snippet; | 421 | self.insert_text_format = InsertTextFormat::Snippet; |
422 | self.insert_text(snippet) | 422 | self.insert_text(snippet) |
423 | } | 423 | } |
424 | pub(crate) fn kind(mut self, kind: impl Into<CompletionItemKind>) -> Builder { | 424 | pub(crate) fn kind(&mut self, kind: impl Into<CompletionItemKind>) -> &mut Builder { |
425 | self.kind = Some(kind.into()); | 425 | self.kind = Some(kind.into()); |
426 | self | 426 | self |
427 | } | 427 | } |
428 | pub(crate) fn text_edit(mut self, edit: TextEdit) -> Builder { | 428 | pub(crate) fn text_edit(&mut self, edit: TextEdit) -> &mut Builder { |
429 | self.text_edit = Some(edit); | 429 | self.text_edit = Some(edit); |
430 | self | 430 | self |
431 | } | 431 | } |
432 | pub(crate) fn snippet_edit(mut self, _cap: SnippetCap, edit: TextEdit) -> Builder { | 432 | pub(crate) fn snippet_edit(&mut self, _cap: SnippetCap, edit: TextEdit) -> &mut Builder { |
433 | self.insert_text_format = InsertTextFormat::Snippet; | 433 | self.insert_text_format = InsertTextFormat::Snippet; |
434 | self.text_edit(edit) | 434 | self.text_edit(edit) |
435 | } | 435 | } |
436 | pub(crate) fn detail(self, detail: impl Into<String>) -> Builder { | 436 | pub(crate) fn detail(&mut self, detail: impl Into<String>) -> &mut Builder { |
437 | self.set_detail(Some(detail)) | 437 | self.set_detail(Some(detail)) |
438 | } | 438 | } |
439 | pub(crate) fn set_detail(mut self, detail: Option<impl Into<String>>) -> Builder { | 439 | pub(crate) fn set_detail(&mut self, detail: Option<impl Into<String>>) -> &mut Builder { |
440 | self.detail = detail.map(Into::into); | 440 | self.detail = detail.map(Into::into); |
441 | if let Some(detail) = &self.detail { | 441 | if let Some(detail) = &self.detail { |
442 | if never!(detail.contains('\n'), "multiline detail:\n{}", detail) { | 442 | if never!(detail.contains('\n'), "multiline detail:\n{}", detail) { |
@@ -446,30 +446,30 @@ impl Builder { | |||
446 | self | 446 | self |
447 | } | 447 | } |
448 | #[allow(unused)] | 448 | #[allow(unused)] |
449 | pub(crate) fn documentation(self, docs: Documentation) -> Builder { | 449 | pub(crate) fn documentation(&mut self, docs: Documentation) -> &mut Builder { |
450 | self.set_documentation(Some(docs)) | 450 | self.set_documentation(Some(docs)) |
451 | } | 451 | } |
452 | pub(crate) fn set_documentation(mut self, docs: Option<Documentation>) -> Builder { | 452 | pub(crate) fn set_documentation(&mut self, docs: Option<Documentation>) -> &mut Builder { |
453 | self.documentation = docs.map(Into::into); | 453 | self.documentation = docs.map(Into::into); |
454 | self | 454 | self |
455 | } | 455 | } |
456 | pub(crate) fn set_deprecated(mut self, deprecated: bool) -> Builder { | 456 | pub(crate) fn set_deprecated(&mut self, deprecated: bool) -> &mut Builder { |
457 | self.deprecated = deprecated; | 457 | self.deprecated = deprecated; |
458 | self | 458 | self |
459 | } | 459 | } |
460 | pub(crate) fn set_relevance(mut self, relevance: Relevance) -> Builder { | 460 | pub(crate) fn set_relevance(&mut self, relevance: Relevance) -> &mut Builder { |
461 | self.relevance = relevance; | 461 | self.relevance = relevance; |
462 | self | 462 | self |
463 | } | 463 | } |
464 | pub(crate) fn trigger_call_info(mut self) -> Builder { | 464 | pub(crate) fn trigger_call_info(&mut self) -> &mut Builder { |
465 | self.trigger_call_info = Some(true); | 465 | self.trigger_call_info = Some(true); |
466 | self | 466 | self |
467 | } | 467 | } |
468 | pub(crate) fn add_import(mut self, import_to_add: Option<ImportEdit>) -> Builder { | 468 | pub(crate) fn add_import(&mut self, import_to_add: Option<ImportEdit>) -> &mut Builder { |
469 | self.import_to_add = import_to_add; | 469 | self.import_to_add = import_to_add; |
470 | self | 470 | self |
471 | } | 471 | } |
472 | pub(crate) fn ref_match(mut self, mutability: Mutability) -> Builder { | 472 | pub(crate) fn ref_match(&mut self, mutability: Mutability) -> &mut Builder { |
473 | self.ref_match = Some(mutability); | 473 | self.ref_match = Some(mutability); |
474 | self | 474 | self |
475 | } | 475 | } |