complete self

2 files changed, 17 insertions, 0 deletions

diff --git a/crates/libeditor/src/completion.rs b/crates/libeditor/src/completion.rs
index 06a607265..f3058c023 100644
--- a/crates/libeditor/src/completion.rs
+++ b/crates/libeditor/src/completion.rs
@@ -142,6 +142,12 @@ fn complete_fn(name_ref: ast::NameRef, scopes: &FnScopes, acc: &mut Vec<Completi
                 snippet: None,
             })
     );
+    if scopes.self_param.is_some() {
+        acc.push(CompletionItem {
+            name: "self".to_string(),
+            snippet: None,
+        })
+    }
 }
 
 #[cfg(test)]
@@ -250,6 +256,13 @@ mod tests {
     }
 
     #[test]
+    fn test_complete_self() {
+        check_scope_completion(r"
+            impl S { fn foo(&self) { <|> } }
+        ", r#"[CompletionItem { name: "self", snippet: None }]"#)
+    }
+
+    #[test]
     fn test_completion_kewords() {
         check_snippet_completion(r"
             fn quux() {
diff --git a/crates/libeditor/src/scope/fn_scope.rs b/crates/libeditor/src/scope/fn_scope.rs
index 5c04e2f9b..78e9c061c 100644
--- a/crates/libeditor/src/scope/fn_scope.rs
+++ b/crates/libeditor/src/scope/fn_scope.rs
@@ -13,6 +13,7 @@ type ScopeId = usize;
 
 #[derive(Debug)]
 pub struct FnScopes {
+    pub self_param: Option<SyntaxNode>,
     scopes: Vec<ScopeData>,
     scope_for: HashMap<SyntaxNode, ScopeId>,
 }
@@ -20,6 +21,9 @@ pub struct FnScopes {
 impl FnScopes {
     pub fn new(fn_def: ast::FnDef) -> FnScopes {
         let mut scopes = FnScopes {
+            self_param: fn_def.param_list()
+                .and_then(|it| it.self_param())
+                .map(|it| it.syntax().owned()),
             scopes: Vec::new(),
             scope_for: HashMap::new()
         };