Merge #56

56: Unify lookahead naming between parser and lexer. r=matklad a=zachlute

Resolves Issue #26.

I wanted to play around with libsyntax2, and fixing a random issue seemed like a good way to mess around in the code.

This PR mostly does what's suggested in that issue. I elected to go with `at` and `at_str` instead of trying to do any fancy overloading shenanigans, because...uh, well, frankly I don't really know how to do any fancy overloading shenanigans. The only really questionable bit is `nth_is_p`, which could also have potentially been named `nth_at_p`, but `is` seemed more apropos.

I also added simple tests for `Ptr` so I could be less terrified I broke something. 

Comments and criticisms very welcome. I'm still pretty new to Rust.

Co-authored-by: Zach Lute <[email protected]>

1 files changed, 8 insertions, 8 deletions

diff --git a/crates/libsyntax2/src/lexer/strings.rs b/crates/libsyntax2/src/lexer/strings.rs
index e6ade54a4..5ff483d14 100644
--- a/crates/libsyntax2/src/lexer/strings.rs
+++ b/crates/libsyntax2/src/lexer/strings.rs
@@ -15,11 +15,11 @@ pub(crate) fn is_string_literal_start(c: char, c1: Option<char>, c2: Option<char
 }
 
 pub(crate) fn scan_char(ptr: &mut Ptr) {
-    while let Some(c) = ptr.next() {
+    while let Some(c) = ptr.current() {
         match c {
             '\\' => {
                 ptr.bump();
-                if ptr.next_is('\\') || ptr.next_is('\'') {
+                if ptr.at('\\') || ptr.at('\'') {
                     ptr.bump();
                 }
             }
@@ -57,11 +57,11 @@ pub(crate) fn scan_byte_char_or_string(ptr: &mut Ptr) -> SyntaxKind {
 }
 
 pub(crate) fn scan_string(ptr: &mut Ptr) {
-    while let Some(c) = ptr.next() {
+    while let Some(c) = ptr.current() {
         match c {
             '\\' => {
                 ptr.bump();
-                if ptr.next_is('\\') || ptr.next_is('"') {
+                if ptr.at('\\') || ptr.at('"') {
                     ptr.bump();
                 }
             }
@@ -78,11 +78,11 @@ pub(crate) fn scan_string(ptr: &mut Ptr) {
 
 pub(crate) fn scan_raw_string(ptr: &mut Ptr) {
     let mut hashes = 0;
-    while ptr.next_is('#') {
+    while ptr.at('#') {
         hashes += 1;
         ptr.bump();
     }
-    if !ptr.next_is('"') {
+    if !ptr.at('"') {
         return;
     }
     ptr.bump();
@@ -90,7 +90,7 @@ pub(crate) fn scan_raw_string(ptr: &mut Ptr) {
     while let Some(c) = ptr.bump() {
         if c == '"' {
             let mut hashes_left = hashes;
-            while ptr.next_is('#') && hashes_left > 0{
+            while ptr.at('#') && hashes_left > 0{
                 hashes_left -= 1;
                 ptr.bump();
             }
@@ -110,7 +110,7 @@ fn scan_byte_string(ptr: &mut Ptr) {
 }
 
 fn scan_raw_byte_string(ptr: &mut Ptr) {
-    if !ptr.next_is('"') {
+    if !ptr.at('"') {
         return;
     }
     ptr.bump();