diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-03-13 13:04:45 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-03-13 13:04:45 +0000 |
| commit | fe4a94fff379e69acf31bf4c8b0d2490107a2dae (patch) | |
| tree | 65f614b2c839379c294f4ea08564d135f5b7ad4c /crates/parser/src/grammar/items/consts.rs | |
| parent | 88f78bdb9b64e0ba4ca5924599e42a524f5c3b64 (diff) | |
| parent | 9117148f42371108f49de84ff765da987dcb5917 (diff) | |
Merge #7994
7994: Speed up mbe matching in heavy recursive cases r=edwin0cheng a=edwin0cheng
In some cases (e.g. #4186), mbe matching is very slow due to a lot of copy and allocation for bindings, this PR try to solve this problem by introduce a semi "link-list" approach for bindings building.
I used this [test case](https://github.com/weiznich/minimal_example_for_rust_81262) (for `features(32-column-tables)`) to run following command to benchmark:
```
time rust-analyzer analysis-stats --load-output-dirs ./
```
Before this PR : 2 mins
After this PR: 3 seconds.
However, for 64-column-tables cases, we still need 4 mins to complete.
I will try to investigate in the following weeks.
bors r+
Co-authored-by: Edwin Cheng <[email protected]>
Diffstat (limited to 'crates/parser/src/grammar/items/consts.rs')
0 files changed, 0 insertions, 0 deletions