diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-04-25 22:18:57 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-04-25 22:18:57 +0100 |
| commit | 617535393bb5ccc7adf0bac8a3b9a9c306454e79 (patch) | |
| tree | c0271bccd902abfbbc429e186d208b9a92ca79db /crates/parser/src/grammar | |
| parent | d8578bf9bf36708ca0095c77e2856c78ed3fd8ec (diff) | |
| parent | 09fc5e1dd7f8635d111c12e745cf782fe3b58d95 (diff) | |
Merge #8658
8658: Check more carefully for cases where a rename can't be done r=Veykril a=dzhu
Attempting to rename an element of a tuple field would previously replace the type with the new name, which doesn't make sense; now it fails instead.
The check is done in both `prepare_rename` and `rename` so that the case is caught before the user is prompted for a new name. Some other existing failure cases are also now additionally checked in `prepare_rename`.
Closes: #8592
(I threw in some doc edits for a relevant type; of course, I can remove those if the policy here is to be strict about scope of changes within a PR.)
Co-authored-by: Danny Zhu <[email protected]>
Diffstat (limited to 'crates/parser/src/grammar')
0 files changed, 0 insertions, 0 deletions