aboutsummaryrefslogtreecommitdiff
path: root/crates/paths
diff options
context:
space:
mode:
authorChayim Refael Friedman <[email protected]>2021-04-18 01:16:38 +0100
committerChayim Refael Friedman <[email protected]>2021-04-18 01:16:38 +0100
commitf92be7eaabe27387a2d860c3842443bf32e99c73 (patch)
tree966d0d870973548ccf771126c23df693b2d392fc /crates/paths
parentbb1d925dab36372c6bd1fb5671bb68ce938ff009 (diff)
Escape characters in doc comments in macros correctly
Previously they were escaped twice, both by `.escape_default()` and the debug view of strings (`{:?}`). This leads to things like newlines or tabs in documentation comments being `\\n`, but we unescape literals only once, ending up with `\n`. This was hard to spot because CMark unescaped them (at least for `'` and `"`), but it did not do so in code blocks. This also was the root cause of #7781. This issue was solved by using `.escape_debug()` instead of `.escape_default()`, but the real issue remained. We can bring the `.escape_default()` back by now, however I didn't do it because it is probably slower than `.escape_debug()` (more work to do), and also in order to change the code the least.
Diffstat (limited to 'crates/paths')
0 files changed, 0 insertions, 0 deletions