Merge #320

320: completion uses hir scopes r=matklad a=matklad



Co-authored-by: Aleksey Kladov <[email protected]>

1 files changed, 23 insertions, 21 deletions

diff --git a/crates/ra_analysis/src/completion/complete_scope.rs b/crates/ra_analysis/src/completion/complete_scope.rs
index 82610d63f..a57670e3b 100644
--- a/crates/ra_analysis/src/completion/complete_scope.rs
+++ b/crates/ra_analysis/src/completion/complete_scope.rs
@@ -10,32 +10,34 @@ pub(super) fn complete_scope(acc: &mut Completions, ctx: &CompletionContext) ->
     if !ctx.is_trivial_path {
         return Ok(());
     }
+    let module = match &ctx.module {
+        Some(it) => it,
+        None => return Ok(()),
+    };
     if let Some(fn_def) = ctx.enclosing_fn {
-        let scopes = hir::FnScopes::new(fn_def);
+        let function = hir::source_binder::function_from_module(ctx.db, module, fn_def);
+        let scopes = function.scopes(ctx.db);
         complete_fn(acc, &scopes, ctx.offset);
     }
 
-    if let Some(module) = &ctx.module {
-        let module_scope = module.scope(ctx.db)?;
-        module_scope
-            .entries()
-            .filter(|(_name, res)| {
-                // Don't expose this item
-                match res.import {
-                    None => true,
-                    Some(import) => {
-                        let range = import.range(ctx.db, module.source().file_id());
-                        !range.is_subrange(&ctx.leaf.range())
-                    }
+    let module_scope = module.scope(ctx.db)?;
+    module_scope
+        .entries()
+        .filter(|(_name, res)| {
+            // Don't expose this item
+            match res.import {
+                None => true,
+                Some(import) => {
+                    let range = import.range(ctx.db, module.source().file_id());
+                    !range.is_subrange(&ctx.leaf.range())
                 }
-            })
-            .for_each(|(name, res)| {
-                CompletionItem::new(CompletionKind::Reference, name.to_string())
-                    .from_resolution(ctx.db, res)
-                    .add_to(acc)
-            });
-    }
-
+            }
+        })
+        .for_each(|(name, res)| {
+            CompletionItem::new(CompletionKind::Reference, name.to_string())
+                .from_resolution(ctx.db, res)
+                .add_to(acc)
+        });
     Ok(())
 }