diff options
| author | Aleksey Kladov <[email protected]> | 2020-04-20 15:34:01 +0100 |
|---|---|---|
| committer | Aleksey Kladov <[email protected]> | 2020-04-20 15:34:01 +0100 |
| commit | 8a04372fec5f26a0650395a1e420fea062b3a7ab (patch) | |
| tree | ede61469d8f4e180f0cfa7cbe00d889737d45551 /crates/ra_assists/src/handlers/add_impl.rs | |
| parent | 90f837829d4f2c1054751de2de695ba1c0b8ae5c (diff) | |
Fix panic in split_imports assist
The fix is admittedly quit literally just papering over.
Long-term, I see two more principled approaches:
* we switch to a fully tree-based impl, without parse . to_string
step; with this approach, there shouldn't be any panics. The results
might be nonsensical, but so was the original input.
* we preserve the invariant that re-parsing constructed node is an
identity, and make all the `make_xxx` method return an `Option`.
closes #4044
Diffstat (limited to 'crates/ra_assists/src/handlers/add_impl.rs')
0 files changed, 0 insertions, 0 deletions