aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_assists/src/handlers/fix_visibility.rs
diff options
context:
space:
mode:
authorVeetaha <[email protected]>2020-06-28 23:18:50 +0100
committerVeetaha <[email protected]>2020-06-28 23:18:50 +0100
commit503f9498cd469c6467250c02bd8f6dbce973dd57 (patch)
treea4809da64326fca4533fa08c2beeb01fb04d160c /crates/ra_assists/src/handlers/fix_visibility.rs
parente75e2ae5b6b6b1364368ceb3d4081b6508b2f001 (diff)
Follow matklad suggestions
- Move vis_offset() to utils.rs - Shorten explicit ra_syntax::ast -> ast - Undo refactoring exhaustive pattern to non-exhaustive
Diffstat (limited to 'crates/ra_assists/src/handlers/fix_visibility.rs')
-rw-r--r--crates/ra_assists/src/handlers/fix_visibility.rs9
1 files changed, 1 insertions, 8 deletions
diff --git a/crates/ra_assists/src/handlers/fix_visibility.rs b/crates/ra_assists/src/handlers/fix_visibility.rs
index 02763c5b9..468f9a77f 100644
--- a/crates/ra_assists/src/handlers/fix_visibility.rs
+++ b/crates/ra_assists/src/handlers/fix_visibility.rs
@@ -6,7 +6,7 @@ use ra_syntax::{
6 SyntaxNode, TextRange, TextSize, 6 SyntaxNode, TextRange, TextSize,
7}; 7};
8 8
9use crate::{AssistContext, AssistId, Assists}; 9use crate::{utils::vis_offset, AssistContext, AssistId, Assists};
10 10
11// FIXME: this really should be a fix for diagnostic, rather than an assist. 11// FIXME: this really should be a fix for diagnostic, rather than an assist.
12 12
@@ -177,13 +177,6 @@ fn target_data_for_def(
177 Some((offset, target, target_file, target_name)) 177 Some((offset, target, target_file, target_name))
178} 178}
179 179
180fn vis_offset(node: &SyntaxNode) -> TextSize {
181 node.children_with_tokens()
182 .find(|it| !matches!(it.kind(), WHITESPACE | COMMENT | ATTR))
183 .map(|it| it.text_range().start())
184 .unwrap_or_else(|| node.text_range().start())
185}
186
187#[cfg(test)] 180#[cfg(test)]
188mod tests { 181mod tests {
189 use crate::tests::{check_assist, check_assist_not_applicable}; 182 use crate::tests::{check_assist, check_assist_not_applicable};