aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_assists/src/handlers/merge_match_arms.rs
diff options
context:
space:
mode:
authorAleksey Kladov <[email protected]>2020-03-19 10:38:26 +0000
committerAleksey Kladov <[email protected]>2020-03-19 10:38:26 +0000
commitef3bf906c477048076faa8e18b50fc34175f6c14 (patch)
tree7e0134f8a0bc0a41e8cbcea91231b7a7be95262b /crates/ra_assists/src/handlers/merge_match_arms.rs
parent5b0a7c7d162c6c30b8fd52309f4473659d647452 (diff)
Generalize
Diffstat (limited to 'crates/ra_assists/src/handlers/merge_match_arms.rs')
-rw-r--r--crates/ra_assists/src/handlers/merge_match_arms.rs10
1 files changed, 4 insertions, 6 deletions
diff --git a/crates/ra_assists/src/handlers/merge_match_arms.rs b/crates/ra_assists/src/handlers/merge_match_arms.rs
index b2a194cb5..eb967ab92 100644
--- a/crates/ra_assists/src/handlers/merge_match_arms.rs
+++ b/crates/ra_assists/src/handlers/merge_match_arms.rs
@@ -1,6 +1,7 @@
1use std::iter::successors; 1use std::iter::successors;
2 2
3use ra_syntax::{ 3use ra_syntax::{
4 algo::neighbor,
4 ast::{self, AstNode}, 5 ast::{self, AstNode},
5 Direction, TextUnit, 6 Direction, TextUnit,
6}; 7};
@@ -53,7 +54,7 @@ pub(crate) fn merge_match_arms(ctx: AssistCtx) -> Option<Assist> {
53 54
54 // We check if the following match arms match this one. We could, but don't, 55 // We check if the following match arms match this one. We could, but don't,
55 // compare to the previous match arm as well. 56 // compare to the previous match arm as well.
56 let arms_to_merge = successors(Some(current_arm), next_arm) 57 let arms_to_merge = successors(Some(current_arm), |it| neighbor(it, Direction::Next))
57 .take_while(|arm| { 58 .take_while(|arm| {
58 if arm.guard().is_some() { 59 if arm.guard().is_some() {
59 return false; 60 return false;
@@ -102,15 +103,12 @@ fn contains_placeholder(a: &ast::MatchArm) -> bool {
102 } 103 }
103} 104}
104 105
105fn next_arm(arm: &ast::MatchArm) -> Option<ast::MatchArm> {
106 arm.syntax().siblings(Direction::Next).skip(1).find_map(ast::MatchArm::cast)
107}
108
109#[cfg(test)] 106#[cfg(test)]
110mod tests { 107mod tests {
111 use super::merge_match_arms;
112 use crate::helpers::{check_assist, check_assist_not_applicable}; 108 use crate::helpers::{check_assist, check_assist_not_applicable};
113 109
110 use super::*;
111
114 #[test] 112 #[test]
115 fn merge_match_arms_single_patterns() { 113 fn merge_match_arms_single_patterns() {
116 check_assist( 114 check_assist(