diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-05-27 13:41:38 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-05-27 13:41:38 +0100 |
| commit | 59adc7bfb6084e946afbea40351c3f6653c37174 (patch) | |
| tree | dad3828436c3f8ee65bd2a2e18d04aa3a094d786 /crates/ra_assists/src/handlers/unwrap_block.rs | |
| parent | 3c5112b079211640ed865ed1d26d8cd2f041c8c4 (diff) | |
| parent | fd83f469e9643c7a9da2d9e4c796bd89c441458d (diff) | |
Merge #4596
4596: Strip leading underscores of argument names in function/method r=matklad a=kuy
Closes #4510
### Goal
When I select a function/method from completions, I get a snippet that doesn't contain leading underscores of argument names.
### Solution
- Option 1: All signatures don't contain underscores
- Option 2: Keep same signature, but inserted snippet doesn't contain underscores
I choose Option 2 because I think that leading underscores is a part of "signature". Users should get correct signatures. On the other hand, trimming underscores is an assist by IDE.
### Other impls.
rls: Complete argument names with underscores (same as actual ra)
IntelliJ Rust: Doesn't complete argument names
VSCode (TypeScript): Doesn't complete argument names
### Working example
Co-authored-by: Yuki Kodama <[email protected]>
Diffstat (limited to 'crates/ra_assists/src/handlers/unwrap_block.rs')
0 files changed, 0 insertions, 0 deletions