diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-03-23 11:55:26 +0000 |
---|---|---|
committer | GitHub <[email protected]> | 2020-03-23 11:55:26 +0000 |
commit | a27f5e3e058abd18925c606c00ee10d0dba45aba (patch) | |
tree | 7d431f92de44991eeb84424850489bf15bdaaa3b /crates/ra_cargo_watch/Cargo.toml | |
parent | c7a2052e7302a5ff6c05aa2589ef3ff51a9e7c95 (diff) | |
parent | 8be28a2d4f1fa1593bab81e32e465dba35b99448 (diff) |
Merge #3632
3632: ra_cargo_watch: log errors r=matklad a=Veetaha
Until this moment we totally ignored all the errors from cargo process. Though this is still true, but we
now try to log ones that are critical (i.e. misconfiguration errors and ignore compile errors).
This fixes #3631, and gives us a better error message to more gracefully handle the #3265
![image](https://user-images.githubusercontent.com/36276403/76958683-d7e1f080-6920-11ea-83d8-04561c11ccc4.png)
Though I think that outputting this only to `Output` channel is not enough. We should somehow warn the user that he passed wrong arguments to `cargo-watch.args`. I didn't bother looking for how to do this now, but this PR at least gives us something.
*cc* @kiljacken @matklad
Co-authored-by: veetaha <[email protected]>
Co-authored-by: Veetaha <[email protected]>
Diffstat (limited to 'crates/ra_cargo_watch/Cargo.toml')
0 files changed, 0 insertions, 0 deletions