Merge #94

94: Extend comments by single word first r=matklad a=kjeremy

Fixes #88

Co-authored-by: Jeremy A. Kolb <[email protected]>

1 files changed, 32 insertions, 4 deletions

diff --git a/crates/ra_editor/src/extend_selection.rs b/crates/ra_editor/src/extend_selection.rs
index b00a457b9..6977900e6 100644
--- a/crates/ra_editor/src/extend_selection.rs
+++ b/crates/ra_editor/src/extend_selection.rs
@@ -16,12 +16,18 @@ pub(crate) fn extend(root: SyntaxNodeRef, range: TextRange) -> Option<TextRange>
         if leaves.clone().all(|it| it.kind() == WHITESPACE) {
             return Some(extend_ws(root, leaves.next()?, offset));
         }
-        let leaf = match leaves {
+        let leaf_range = match leaves {
             LeafAtOffset::None => return None,
-            LeafAtOffset::Single(l) => l,
-            LeafAtOffset::Between(l, r) => pick_best(l, r),
+            LeafAtOffset::Single(l) => {
+                if l.kind() == COMMENT {
+                    extend_single_word_in_comment(l, offset).unwrap_or_else(||l.range())
+                } else {
+                    l.range()
+                }
+            },
+            LeafAtOffset::Between(l, r) => pick_best(l, r).range(),
         };
-        return Some(leaf.range());
+        return Some(leaf_range);
     };
     let node = find_covering_node(root, range);
     if node.kind() == COMMENT && range == node.range() {
@@ -36,6 +42,20 @@ pub(crate) fn extend(root: SyntaxNodeRef, range: TextRange) -> Option<TextRange>
     }
 }
 
+fn extend_single_word_in_comment(leaf: SyntaxNodeRef, offset: TextUnit) -> Option<TextRange> {
+    let text : &str = leaf.leaf_text()?;
+    let cursor_position: u32 = (offset - leaf.range().start()).into();
+
+    let (before, after) = text.split_at(cursor_position as usize);
+    let start_idx = before.rfind(char::is_whitespace)? as u32;
+    let end_idx = after.find(char::is_whitespace)? as u32;
+
+    let from : TextUnit = (start_idx + 1).into();
+    let to : TextUnit = (cursor_position + end_idx).into();
+
+    Some(TextRange::from_to(from, to))
+}
+
 fn extend_ws(root: SyntaxNodeRef, ws: SyntaxNodeRef, offset: TextUnit) -> TextRange {
     let ws_text = ws.leaf_text().unwrap();
     let suffix = TextRange::from_to(offset, ws.range().end()) - ws.range().start();
@@ -176,4 +196,12 @@ fn main() { foo+<|>bar;}
             &["'a", "<'a>"]
         );
     }
+
+    #[test]
+    fn test_extend_selection_select_first_word() {
+        do_check(
+            r#"// foo bar b<|>az quxx"#,
+            &["baz", "// foo bar baz quxx"]
+        );
+    }
 }