diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-04-07 07:48:04 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-04-07 07:48:04 +0100 |
| commit | 25596e1e1a579eb7643fda1d8013925342ea5a1e (patch) | |
| tree | 141457681118671f58c055321b6a8f80f713224a /crates/ra_flycheck/src/lib.rs | |
| parent | c859a6480af7baece2eec38c19f71cb714db9e3b (diff) | |
| parent | 8f7fceeb9ceab6383deae8895c88b3ba53f8dabe (diff) | |
Merge #3872
3872: fix cargo check config with custom command r=matklad a=JoshMcguigan
fixes #3871
Previously if `get::<Vec<String>>(value, "/checkOnSave/overrideCommand")` returned `Some` we'd never execute `set(value, "/checkOnSave/command", command)`, even if the `overrideCommand` was empty.
I am not sure of the best way to prove this, but I believe the LSP clients send this config with a default value if it is not set by the user, which means `get::<Vec<String>>(value, "/checkOnSave/overrideCommand")` would return `Some(vec![])` and thus we'd never set the command to the user specified value (in the case of #3871, "clippy").
I have tested this fix manually by installing this modified version of rust-analyzer and verifying I can see clippy lints in my editor (`coc.nvim`) with `rust-analyzer.checkOnSave.command": "clippy"`.
As best I can tell this would have affected rustfmt extra args too, so this PR also applies the same fix there.
Co-authored-by: Josh Mcguigan <[email protected]>
Diffstat (limited to 'crates/ra_flycheck/src/lib.rs')
0 files changed, 0 insertions, 0 deletions