diff options
author | bors[bot] <bors[bot]@users.noreply.github.com> | 2019-03-23 08:07:30 +0000 |
---|---|---|
committer | bors[bot] <bors[bot]@users.noreply.github.com> | 2019-03-23 08:07:30 +0000 |
commit | 3d7a330f320ac2ebf73df012556d64be9b120445 (patch) | |
tree | b96c4a3c4f1165fd394ce3a854dbe9e02d370a92 /crates/ra_hir/src/ty/lower.rs | |
parent | 15189bc7249fc68a1df0234721514b677a90a305 (diff) | |
parent | 4fd8cfd6adc554752a63aed9ed71d44b372ec4dc (diff) |
Merge #990
990: Forbid TODO markers on master branch r=matklad a=matklad
this makes TODO markers useful for things which you want to fix before sending a PR
Co-authored-by: Aleksey Kladov <[email protected]>
Diffstat (limited to 'crates/ra_hir/src/ty/lower.rs')
-rw-r--r-- | crates/ra_hir/src/ty/lower.rs | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/crates/ra_hir/src/ty/lower.rs b/crates/ra_hir/src/ty/lower.rs index 7f9af307b..003a89f0d 100644 --- a/crates/ra_hir/src/ty/lower.rs +++ b/crates/ra_hir/src/ty/lower.rs | |||
@@ -60,7 +60,7 @@ impl Ty { | |||
60 | 60 | ||
61 | pub(crate) fn from_hir_path(db: &impl HirDatabase, resolver: &Resolver, path: &Path) -> Self { | 61 | pub(crate) fn from_hir_path(db: &impl HirDatabase, resolver: &Resolver, path: &Path) -> Self { |
62 | if let Some(name) = path.as_ident() { | 62 | if let Some(name) = path.as_ident() { |
63 | // TODO handle primitive type names in resolver as well? | 63 | // FIXME handle primitive type names in resolver as well? |
64 | if let Some(int_ty) = primitive::IntTy::from_type_name(name) { | 64 | if let Some(int_ty) = primitive::IntTy::from_type_name(name) { |
65 | return Ty::simple(TypeCtor::Int(primitive::UncertainIntTy::Known(int_ty))); | 65 | return Ty::simple(TypeCtor::Int(primitive::UncertainIntTy::Known(int_ty))); |
66 | } else if let Some(float_ty) = primitive::FloatTy::from_type_name(name) { | 66 | } else if let Some(float_ty) = primitive::FloatTy::from_type_name(name) { |
@@ -87,7 +87,7 @@ impl Ty { | |||
87 | Some(Resolution::GenericParam(idx)) => { | 87 | Some(Resolution::GenericParam(idx)) => { |
88 | return Ty::Param { | 88 | return Ty::Param { |
89 | idx, | 89 | idx, |
90 | // TODO: maybe return name in resolution? | 90 | // FIXME: maybe return name in resolution? |
91 | name: path | 91 | name: path |
92 | .as_ident() | 92 | .as_ident() |
93 | .expect("generic param should be single-segment path") | 93 | .expect("generic param should be single-segment path") |
@@ -139,7 +139,7 @@ impl Ty { | |||
139 | } | 139 | } |
140 | } | 140 | } |
141 | // add placeholders for args that were not provided | 141 | // add placeholders for args that were not provided |
142 | // TODO: handle defaults | 142 | // FIXME: handle defaults |
143 | let supplied_params = substs.len(); | 143 | let supplied_params = substs.len(); |
144 | for _ in supplied_params..def_generics.count_params_including_parent() { | 144 | for _ in supplied_params..def_generics.count_params_including_parent() { |
145 | substs.push(Ty::Unknown); | 145 | substs.push(Ty::Unknown); |