diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-03-10 20:35:45 +0000 |
---|---|---|
committer | GitHub <[email protected]> | 2020-03-10 20:35:45 +0000 |
commit | 0714a065d578e8b22b0451bfc64378c875fe858f (patch) | |
tree | 75665c712625782d88e03447fcd10245c903d6f8 /crates/ra_hir_def/src/body.rs | |
parent | e5df8c402847d5bedb8ebcb621aac46dbe215cdd (diff) | |
parent | adc7b8ea2d0ff1dafecaa697638825463f4b8891 (diff) |
Merge #3552
3552: Fix completion with a partially unknown type r=matklad a=flodiebold
To test whether the receiver type matches for the impl, we unify the given self
type (in this case `HashSet<{unknown}>`) with the self type of the
impl (`HashSet<?0>`), but if the given self type contains Unknowns, they won't
be unified with the variables in those places. So we got a receiver type that
was different from the expected one, and concluded the impl doesn't match.
The fix is slightly hacky; if after the unification, our variables are still
there, we make them fall back to Unknown. This does make some sense though,
since we don't want to 'leak' the variables.
Fixes #3547.
Co-authored-by: Florian Diebold <[email protected]>
Diffstat (limited to 'crates/ra_hir_def/src/body.rs')
0 files changed, 0 insertions, 0 deletions