diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-03-16 10:26:31 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-03-16 10:26:31 +0000 |
| commit | 200c275c2e9955371e61f6ad7684084655df46fc (patch) | |
| tree | c4b61de644cec37cffca9010d56afc4136d23ca8 /crates/ra_hir_def/src/dyn_map.rs | |
| parent | a99cac671c3e6105a0192acbb1a91cb83e453018 (diff) | |
| parent | 5a0041c5aaeee49be84ce771fb0360ae55cbd8b2 (diff) | |
Merge #3534
3534: Feature: vscode impl nightlies download and installation r=Veetaha a=Veetaha
I need to test things more, but the core shape of the code is quite well-formed.
The main problem is that we save the release date only for nightlies and there are no means to get the release date of the stable extension (i.e. for this we would need to consult the github releases via a network request, or we would need to somehow save this info into package.json or any other file accessible from the extension code during the deployment step, but this will be very hard I guess).
So there is an invariant that the users can install nightly only from our extension and they can't do it manually, because when installing the nightly `.vsix` we actually save its release date to `globalState`
Closes: #3402
TODO:
- [x] More manual tests and documentation
cc @matklad @lnicola
Co-authored-by: Veetaha <[email protected]>
Co-authored-by: Veetaha <[email protected]>
Diffstat (limited to 'crates/ra_hir_def/src/dyn_map.rs')
0 files changed, 0 insertions, 0 deletions