diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-07-02 10:12:46 +0100 |
---|---|---|
committer | GitHub <[email protected]> | 2020-07-02 10:12:46 +0100 |
commit | 57ed622ec4f0f71a618f99a46aa0026e81eb2583 (patch) | |
tree | 85d2e22a7e6eeaf34f2d61e4d61721f8771d3af9 /crates/ra_hir_def/src/nameres/tests | |
parent | e5f8fb3e91fdc1e372ef31556d88296a054117d9 (diff) | |
parent | cc77bdf59ad99d3522663ebdb80be553f2767290 (diff) | |
parent | 83588a1c452dff3ca6cd9e84cbe70a3b549fc851 (diff) | |
parent | 69b6f6def525d33a60a3a992960d1085403d3b60 (diff) | |
parent | 6a6ce616aa8da460a145a8d535357adef9f51678 (diff) | |
parent | f1986be8fdcdc01c580b2d6e43574ae980d38e4b (diff) |
Merge #5089 #5161 #5184 #5185 #5186
5089: Disable auto-complete on comments r=matklad a=BGluth
Resolves #4907 by disabling any auto-completion on comments.
As flodiebold [pointed out](https://github.com/rust-analyzer/rust-analyzer/issues/4907#issuecomment-648439979), in the future we may want to support some form of auto-completion within doc comments, but for now it was suggested to just disable auto-completion on them entirely.
The implementation involves adding a new field `is_comment` to `CompletionContext` and checking if the immediate token we auto-completed on is a comment. I couldn't see a case where we need to check any of the ancestors, but let me know if this is not sufficient. I also wasn't sure if it was necessary to add a new field to this struct, but I decided it's probably the best option if we want to potentially do auto-completion on doc comments in the future.
Finally, the three tests I added should I think ideally not filter results by `CompletionKind::Keyword`, but if I want to get unfiltered results, I need access to a non-public function [get_all_completion_items](https://github.com/rust-analyzer/rust-analyzer/blob/9a4d02faf9c47f401b8756c3f7fcab2198f5f9cd/crates/ra_ide/src/completion/test_utils.rs#L32-L39) which I don't know if I should make public just for this.
5161: SSR: Add initial support for placeholder constraints r=matklad a=davidlattimore
5184: Always install required nightly extension if current one is not nightly r=matklad a=Veetaha
This is weird, but having switched back to stable by uninstalling the extension appears that vscode doesn't destroy the `PersistentState` and thus changing to `nightly` channel doesn't work because the last check for nightly extension was less than 1 hour ago. The simple solution is to skip this check if we know that the current extension version is not nightly.
5185: Force showing extension activation error pop-up notification r=matklad a=Veetaha
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/5091
5186: fix: correct pd/ppd/tfn/tmod completion doc r=matklad a=fannheyward
https://github.com/rust-analyzer/rust-analyzer/blob/a33eefa3b26000b3018e6bb873f18dbe15ab4ab7/crates/ra_ide/src/completion/complete_snippet.rs#L23-L24
Co-authored-by: BGluth <[email protected]>
Co-authored-by: David Lattimore <[email protected]>
Co-authored-by: Veetaha <[email protected]>
Co-authored-by: Heyward Fann <[email protected]>