aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_hir_def/src/path/lower
diff options
context:
space:
mode:
authorbors[bot] <26634292+bors[bot]@users.noreply.github.com>2020-03-31 13:45:39 +0100
committerGitHub <[email protected]>2020-03-31 13:45:39 +0100
commitd63bb8565e129f51fadf6a036683b1eedefb78dd (patch)
tree85194d956ce16ef5113c7b08e1d09ec6795ddee1 /crates/ra_hir_def/src/path/lower
parenta932ccd53da3d2179e5e36ae4fbcbf82f3e0bd25 (diff)
parent331d1db3174853a435991c9341367c235e89eca4 (diff)
Merge #3781
3781: Add crate versions when running cargo -p commands. r=matklad a=o0Ignition0o If someone (unfortunately) creates a project that happens to have the same name as one of its (future) dependencies, there is [a way for them to change the dependency's alias in the Cargo.toml file](https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#renaming-dependencies-in-cargotoml), to mitigate the name conflict. Unfortunately cargo -p commands don't seem to pick it up, which seems to put rust-analyzer run commands in a tough situation: ``` > Executing task: cargo test --package config --example default -- tests --nocapture < error: There are multiple `config` packages in your project, and the specification `config` is ambiguous. Please re-run this command with `-p <spec>` where `<spec>` is one of the following: config:0.1.0 config:0.9.3 The terminal process terminated with exit code: 101 ``` cargo suggests us to be more specific and refer to a package by its name and version, which this PR achieves. I passed the version as a String because I don't really understand how the ra_db types work, but I would love to switch it to [a fully fledged Version type](https://steveklabnik.github.io/semver/semver/index.html) if you guide me towards that :) Co-authored-by: o0Ignition0o <[email protected]>
Diffstat (limited to 'crates/ra_hir_def/src/path/lower')
0 files changed, 0 insertions, 0 deletions