diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-03-16 16:42:58 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-03-16 16:42:58 +0000 |
| commit | adcc89137d3feea8f19fad461bbde6f4bce048e5 (patch) | |
| tree | 160af959553ce57fdfcbc0a6c79bafcc3611aeea /crates/ra_hir_expand/src/hygiene.rs | |
| parent | 648df02953a6ebf87a5876668eceba208687e8a7 (diff) | |
| parent | 9faea2364dee4fbc9391ad233c570b70256ef002 (diff) | |
Merge #3584
3584: Switch to dynamic dispatch r=matklad a=matklad
Benches are in https://github.com/rust-analyzer/rust-analyzer/issues/1987#issuecomment-598807185
TL;DR:
* 33% faster release build
* slightly worse/same perf
* no changes for debug build
* slightly smaller binary
cc @flodiebold I genuinely don't know if it is a good idea or not.
Co-authored-by: Aleksey Kladov <[email protected]>
Diffstat (limited to 'crates/ra_hir_expand/src/hygiene.rs')
| -rw-r--r-- | crates/ra_hir_expand/src/hygiene.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/crates/ra_hir_expand/src/hygiene.rs b/crates/ra_hir_expand/src/hygiene.rs index cb554ae4b..dfbac494f 100644 --- a/crates/ra_hir_expand/src/hygiene.rs +++ b/crates/ra_hir_expand/src/hygiene.rs | |||
| @@ -19,7 +19,7 @@ pub struct Hygiene { | |||
| 19 | } | 19 | } |
| 20 | 20 | ||
| 21 | impl Hygiene { | 21 | impl Hygiene { |
| 22 | pub fn new(db: &impl AstDatabase, file_id: HirFileId) -> Hygiene { | 22 | pub fn new(db: &dyn AstDatabase, file_id: HirFileId) -> Hygiene { |
| 23 | let def_crate = match file_id.0 { | 23 | let def_crate = match file_id.0 { |
| 24 | HirFileIdRepr::FileId(_) => None, | 24 | HirFileIdRepr::FileId(_) => None, |
| 25 | HirFileIdRepr::MacroFile(macro_file) => match macro_file.macro_call_id { | 25 | HirFileIdRepr::MacroFile(macro_file) => match macro_file.macro_call_id { |