diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-02-17 10:54:32 +0000 |
---|---|---|
committer | GitHub <[email protected]> | 2020-02-17 10:54:32 +0000 |
commit | fcf15cc05afaeda6880664777ff2a3db342ea088 (patch) | |
tree | ac34e90a9884d7166daa5022ea402196483c26c0 /crates/ra_hir_expand | |
parent | 334f53465f5baf5094844ab3ca2d28e477d07b24 (diff) | |
parent | 0e260aa6b15d9dc8c067adb05f3774aec3fb66ec (diff) |
Merge #3169
3169: Show record field names in Enum completion r=flodiebold a=adamrk
Adresses https://github.com/rust-analyzer/rust-analyzer/issues/2947.
Previously the details shown when autocompleting an Enum variant would look like the variant was a tuple even if it was a record:
![2020-02-16-15:59:32_crop](https://user-images.githubusercontent.com/16367467/74607233-64f21980-50d7-11ea-99db-e973e29c71d7.png)
This change will show the names of the fields for a record and use curly braces instead of parentheses:
![2020-02-16-15:33:00_crop](https://user-images.githubusercontent.com/16367467/74607251-8ce17d00-50d7-11ea-9d4d-38d198a4aec0.png)
This required exposing the type `adt::StructKind` from `ra_hir` and adding a function
```
kind(self, db: &impl HirDatabase) -> StructKind
```
in the `impl` of `EnumVariant`.
There was also a previously existing function `is_unit(self, db: &impl HirDatabase) -> bool` for `EnumVariant` which I removed because it seemed redundant after adding `kind`.
Co-authored-by: adamrk <[email protected]>
Diffstat (limited to 'crates/ra_hir_expand')
0 files changed, 0 insertions, 0 deletions