don't complete top level attrs inside nested attrs and add better labels #4890

Signed-off-by: Benjamin Coenen <[email protected]>

1 files changed, 8 insertions, 16 deletions

diff --git a/crates/ra_ide/src/completion/complete_attribute.rs b/crates/ra_ide/src/completion/complete_attribute.rs
index 814d7109d..9c7ccc950 100644
--- a/crates/ra_ide/src/completion/complete_attribute.rs
+++ b/crates/ra_ide/src/completion/complete_attribute.rs
@@ -22,24 +22,18 @@ pub(super) fn complete_attribute(acc: &mut Completions, ctx: &CompletionContext)
         }
         (_, Some(ast::AttrInput::TokenTree(token_tree))) => {
             let token_tree_str = token_tree.to_string();
-            complete_attribute_start(
-                acc,
-                ctx,
-                attribute,
-                token_tree_str.starts_with('(') && token_tree_str.ends_with(')'),
-            )
+            let nested = token_tree_str.starts_with('(') && token_tree_str.ends_with(')');
+
+            if !nested {
+                complete_attribute_start(acc, ctx, attribute);
+            }
         }
-        _ => complete_attribute_start(acc, ctx, attribute, false),
+        _ => complete_attribute_start(acc, ctx, attribute),
     }
     Some(())
 }
 
-fn complete_attribute_start(
-    acc: &mut Completions,
-    ctx: &CompletionContext,
-    attribute: &ast::Attr,
-    nested: bool,
-) {
+fn complete_attribute_start(acc: &mut Completions, ctx: &CompletionContext, attribute: &ast::Attr) {
     for attr_completion in ATTRIBUTES {
         let mut item = CompletionItem::new(
             CompletionKind::Attribute,
@@ -56,9 +50,7 @@ fn complete_attribute_start(
         }
 
         if attribute.kind() == ast::AttrKind::Inner || !attr_completion.should_be_inner {
-            if (nested && attr_completion.should_be_inner) || !nested {
-                acc.add(item);
-            }
+            acc.add(item);
         }
     }
 }