diff options
| author | bors[bot] <bors[bot]@users.noreply.github.com> | 2019-05-23 18:23:17 +0100 |
|---|---|---|
| committer | bors[bot] <bors[bot]@users.noreply.github.com> | 2019-05-23 18:23:17 +0100 |
| commit | 1dc9adc6e27d603f05f794adda91bca8b6dec8ac (patch) | |
| tree | c2ebe02614abf66618ed3975f7108cd03689416a /crates/ra_ide_api/src/completion/complete_fn_param.rs | |
| parent | ef00b5af1c7a7a7cac685eff661a10252825d84a (diff) | |
| parent | 5d54aa678153d0af0edc8b4dd2d74709d10ca66c (diff) | |
Merge #1290
1290: Add Union to code_model r=matklad a=matklad
@flodiebold I am conflicted about two possible implementation approaches:
* we can add a separate `struct Union` to code model
* we can add `fn is_union(&self)` to existing `Struct`
This PR goes with the former approach, because it seems like Unions are sufficiently different in semantics to warrant a separate types. Which is in contrast to Syntax Tree, where both structs and unions share the same node kind, because their syntax is the same.
What would be the right thing to do here?
Co-authored-by: Aleksey Kladov <[email protected]>
Diffstat (limited to 'crates/ra_ide_api/src/completion/complete_fn_param.rs')
0 files changed, 0 insertions, 0 deletions