Merge #1388

1388: Remove NavigationTarget::node and fill docs and description in during construction r=matklad a=edwin0cheng

Related dissused:

 https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/MBE.20discussion/near/167105559

Co-authored-by: Edwin Cheng <[email protected]>

1 files changed, 91 insertions, 0 deletions

diff --git a/crates/ra_ide_api/src/display/short_label.rs b/crates/ra_ide_api/src/display/short_label.rs
new file mode 100644
index 000000000..dc8245c34
--- /dev/null
+++ b/crates/ra_ide_api/src/display/short_label.rs
@@ -0,0 +1,91 @@
+use ra_syntax::{
+    ast::{self, NameOwner, VisibilityOwner, TypeAscriptionOwner, AstNode},
+};
+
+pub(crate) trait ShortLabel {
+    fn short_label(&self) -> Option<String>;
+}
+
+impl ShortLabel for ast::FnDef {
+    fn short_label(&self) -> Option<String> {
+        Some(crate::display::function_label(self))
+    }
+}
+
+impl ShortLabel for ast::StructDef {
+    fn short_label(&self) -> Option<String> {
+        short_label_from_node(self, "struct ")
+    }
+}
+
+impl ShortLabel for ast::EnumDef {
+    fn short_label(&self) -> Option<String> {
+        short_label_from_node(self, "enum ")
+    }
+}
+
+impl ShortLabel for ast::TraitDef {
+    fn short_label(&self) -> Option<String> {
+        short_label_from_node(self, "trait ")
+    }
+}
+
+impl ShortLabel for ast::Module {
+    fn short_label(&self) -> Option<String> {
+        short_label_from_node(self, "mod ")
+    }
+}
+
+impl ShortLabel for ast::TypeAliasDef {
+    fn short_label(&self) -> Option<String> {
+        short_label_from_node(self, "type ")
+    }
+}
+
+impl ShortLabel for ast::ConstDef {
+    fn short_label(&self) -> Option<String> {
+        short_label_from_ascribed_node(self, "const ")
+    }
+}
+
+impl ShortLabel for ast::StaticDef {
+    fn short_label(&self) -> Option<String> {
+        short_label_from_ascribed_node(self, "static ")
+    }
+}
+
+impl ShortLabel for ast::NamedFieldDef {
+    fn short_label(&self) -> Option<String> {
+        short_label_from_ascribed_node(self, "")
+    }
+}
+
+impl ShortLabel for ast::EnumVariant {
+    fn short_label(&self) -> Option<String> {
+        Some(self.name()?.text().to_string())
+    }
+}
+
+fn short_label_from_ascribed_node<T>(node: &T, prefix: &str) -> Option<String>
+where
+    T: NameOwner + VisibilityOwner + TypeAscriptionOwner,
+{
+    let mut buf = short_label_from_node(node, prefix)?;
+
+    if let Some(type_ref) = node.ascribed_type() {
+        buf.push_str(": ");
+        type_ref.syntax().text().push_to(&mut buf);
+    }
+
+    Some(buf)
+}
+
+fn short_label_from_node<T>(node: &T, label: &str) -> Option<String>
+where
+    T: NameOwner + VisibilityOwner,
+{
+    let mut buf = node.visibility().map(|v| format!("{} ", v.syntax().text())).unwrap_or_default();
+    buf.push_str(label);
+    buf.push_str(node.name()?.text().as_str());
+    Some(buf)
+}