Merge #3220

3220: Fix clippy warnings, update Cargo.toml versions r=matklad a=SomeoneToIgnore

In the `cargo xtask lint` ouptut, there were two interesting Clippy warnings that might be interesting to investigate further:

* warning: this argument (4 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)

* warning: large size difference between variants

Co-authored-by: Kirill Bulatov <[email protected]>

2 files changed, 11 insertions, 10 deletions

diff --git a/crates/ra_ide_db/Cargo.toml b/crates/ra_ide_db/Cargo.toml
index dbe98f3a0..ee409e34e 100644
--- a/crates/ra_ide_db/Cargo.toml
+++ b/crates/ra_ide_db/Cargo.toml
@@ -11,17 +11,18 @@ doctest = false
 wasm = []
 
 [dependencies]
-either = "1.5"
+either = "1.5.3"
 format-buf = "1.0.0"
-indexmap = "1.3.0"
-itertools = "0.8.0"
+indexmap = "1.3.2"
+itertools = "0.8.2"
 join_to_string = "0.1.3"
-log = "0.4.5"
-rayon = "1.0.2"
-fst = { version = "0.3.1", default-features = false }
-rustc-hash = "1.0"
+log = "0.4.8"
+rayon = "1.3.0"
+fst = { version = "0.3.5", default-features = false }
+rustc-hash = "1.1.0"
+unicase = "2.6.0"
 superslice = "1.0.0"
-once_cell = "1.2.0"
+once_cell = "1.3.1"
 
 ra_syntax = { path = "../ra_syntax" }
 ra_text_edit = { path = "../ra_text_edit" }
@@ -36,4 +37,4 @@ test_utils = { path = "../test_utils" }
 hir = { path = "../ra_hir", package = "ra_hir" }
 
 [dev-dependencies]
-insta = "0.13.0"
+insta = "0.13.1"
diff --git a/crates/ra_ide_db/src/change.rs b/crates/ra_ide_db/src/change.rs
index 4668784d3..7e9310005 100644
--- a/crates/ra_ide_db/src/change.rs
+++ b/crates/ra_ide_db/src/change.rs
@@ -44,7 +44,7 @@ impl fmt::Debug for AnalysisChange {
         if !self.libraries_added.is_empty() {
             d.field("libraries_added", &self.libraries_added.len());
         }
-        if !self.crate_graph.is_none() {
+        if self.crate_graph.is_some() {
             d.field("crate_graph", &self.crate_graph);
         }
         d.finish()