Merge #162

162: Db everywhere r=matklad a=matklad

This PR continues our switch to salsa.

Now *all* state is handled by a single salsa database.

Co-authored-by: Aleksey Kladov <[email protected]>

1 files changed, 19 insertions, 7 deletions

diff --git a/crates/ra_lsp_server/src/path_map.rs b/crates/ra_lsp_server/src/path_map.rs
index d32829382..d5957d673 100644
--- a/crates/ra_lsp_server/src/path_map.rs
+++ b/crates/ra_lsp_server/src/path_map.rs
@@ -1,4 +1,7 @@
-use std::path::{Component, Path, PathBuf};
+use std::{
+    fmt,
+    path::{Component, Path, PathBuf},
+};
 
 use im;
 use ra_analysis::{FileId, FileResolver};
@@ -10,7 +13,7 @@ pub enum Root {
     Lib,
 }
 
-#[derive(Debug, Default, Clone)]
+#[derive(Default, Clone)]
 pub struct PathMap {
     next_id: u32,
     path2id: im::HashMap<PathBuf, FileId>,
@@ -18,19 +21,28 @@ pub struct PathMap {
     id2root: im::HashMap<FileId, Root>,
 }
 
+impl fmt::Debug for PathMap {
+    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
+        f.write_str("PathMap { ... }")
+    }
+}
+
 impl PathMap {
     pub fn new() -> PathMap {
         Default::default()
     }
-    pub fn get_or_insert(&mut self, path: PathBuf, root: Root) -> FileId {
-        self.path2id
+    pub fn get_or_insert(&mut self, path: PathBuf, root: Root) -> (bool, FileId) {
+        let mut inserted = false;
+        let file_id = self.path2id
             .get(path.as_path())
             .map(|&id| id)
             .unwrap_or_else(|| {
+                inserted = true;
                 let id = self.new_file_id();
                 self.insert(path, id, root);
                 id
-            })
+            });
+        (inserted, file_id)
     }
     pub fn get_id(&self, path: &Path) -> Option<FileId> {
         self.path2id.get(path).map(|&id| id)
@@ -105,8 +117,8 @@ mod test {
     #[test]
     fn test_resolve() {
         let mut m = PathMap::new();
-        let id1 = m.get_or_insert(PathBuf::from("/foo"), Root::Workspace);
-        let id2 = m.get_or_insert(PathBuf::from("/foo/bar.rs"), Root::Workspace);
+        let (_, id1) = m.get_or_insert(PathBuf::from("/foo"), Root::Workspace);
+        let (_, id2) = m.get_or_insert(PathBuf::from("/foo/bar.rs"), Root::Workspace);
         assert_eq!(m.resolve(id1, &RelativePath::new("bar.rs")), Some(id2),)
     }
 }