diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2019-11-30 10:43:35 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2019-11-30 10:43:35 +0000 |
| commit | 7cecd0f331419439417f98d92b839c9aaa06ed86 (patch) | |
| tree | 81d80ad945bb9816536524301f1e60f78690959a /crates/ra_lsp_server | |
| parent | 10c8e5eecb97f8f89e599d27df658cbcc3015c8e (diff) | |
| parent | b3856568af3a21bfd13584e06fce852f84811fdb (diff) | |
Merge #2449
2449: Only allow renames to valid identifiers r=matklad a=detrumi
Implements #2121
Co-authored-by: Wilco Kusee <[email protected]>
Diffstat (limited to 'crates/ra_lsp_server')
| -rw-r--r-- | crates/ra_lsp_server/src/main_loop/handlers.rs | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/crates/ra_lsp_server/src/main_loop/handlers.rs b/crates/ra_lsp_server/src/main_loop/handlers.rs index c81fa7f67..ca47ff5e1 100644 --- a/crates/ra_lsp_server/src/main_loop/handlers.rs +++ b/crates/ra_lsp_server/src/main_loop/handlers.rs | |||
| @@ -480,8 +480,6 @@ pub fn handle_prepare_rename( | |||
| 480 | let _p = profile("handle_prepare_rename"); | 480 | let _p = profile("handle_prepare_rename"); |
| 481 | let position = params.try_conv_with(&world)?; | 481 | let position = params.try_conv_with(&world)?; |
| 482 | 482 | ||
| 483 | // We support renaming references like handle_rename does. | ||
| 484 | // In the future we may want to reject the renaming of things like keywords here too. | ||
| 485 | let optional_change = world.analysis().rename(position, "dummy")?; | 483 | let optional_change = world.analysis().rename(position, "dummy")?; |
| 486 | let range = match optional_change { | 484 | let range = match optional_change { |
| 487 | None => return Ok(None), | 485 | None => return Ok(None), |