aboutsummaryrefslogtreecommitdiff
path: root/crates/ra_syntax/src/ast/tokens.rs
diff options
context:
space:
mode:
authorRyan Cumming <[email protected]>2019-06-30 01:49:07 +0100
committerRyan Cumming <[email protected]>2019-06-30 02:12:56 +0100
commit8f726b7db65d3d9527cdb2fb682c195ad1446dbf (patch)
tree82e44d62f3742c625b47a1cfb30e22573604c9fd /crates/ra_syntax/src/ast/tokens.rs
parent27df89f47d5f0a6e8e62d517d98dda854efabc34 (diff)
Include primary span label in VS Code diagnostics
In most cases the primary label span repeats information found elsewhere in the diagnostic. For example, with E0061: ``` { "message": "this function takes 2 parameters but 3 parameters were supplied", "spans": [{"label": "expected 2 parameters"}] } ``` However, with some mismatched type errors (E0308) the expected type only appears in the primary span's label, e.g.: ``` { "message": "mismatched types", "spans": [{"label": "expected usize, found u32"}] } ``` I initially added the primary span label to the message unconditionally. However, for most error types the child diagnostics repeat the primary span label with more detail. `rustc` also renders the duplicate text but because the span label and child diagnostics appear in visually distinct places it's not as confusing. This takes a heuristic approach where it will only add the primary span label if there are no child message lines.
Diffstat (limited to 'crates/ra_syntax/src/ast/tokens.rs')
0 files changed, 0 insertions, 0 deletions