diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-05-02 13:44:55 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-05-02 13:44:55 +0100 |
| commit | 89e1f97515c36ab97bd378d972cabec0feb6d77e (patch) | |
| tree | b1c66214d527a8d5d58c95cfa10d37538a787cd5 /crates/ra_syntax/test_data/parser/fuzz-failures/0000.rs | |
| parent | a2ae2bbb833be6874a420eaa33dcb28c89f7590d (diff) | |
| parent | fdf86637bf8338ad19923442a547c6c7b495100c (diff) | |
| parent | 65234e8828defc0a56cb1d5e20793b5163b5330d (diff) | |
Merge #4207 #4253
4207: Add unwrap block assist #4156 r=matklad a=bnjjj
close issue #4156
4253: Remove `workspaceLoaded` setting r=matklad a=eminence
The `workspaceLoaded` notification setting was originally designed to
control the display of a popup message that said:
"workspace loaded, {} rust packages"
This popup was removed and replaced by a much sleeker message in the
VSCode status bar that provides a real-time status while loading:
rust-analyzer: {}/{} packages
This was done as part of #3587
The change in this PR simply renames this setting from `workspaceLoaded` to
`progress` to better describe what it actually controls. At the moment,
the only type of progress message that is controlled by this setting is
the initial load messages, but in theory other messages could also be
controlled by this setting.
Reviewer notes:
* If we didn't like the idea of causing minor breaking to user's config, we could keep the setting name as `workspaceLoaded`
* I think we can now close both #2719 and #3176 since the notification dialog in question no longer exists (actually I think you can close those issues even if you reject this PR 😄 )
Co-authored-by: Benjamin Coenen <[email protected]>
Co-authored-by: Andrew Chin <[email protected]>