diff options
| author | bors[bot] <bors[bot]@users.noreply.github.com> | 2019-01-10 12:20:00 +0000 |
|---|---|---|
| committer | bors[bot] <bors[bot]@users.noreply.github.com> | 2019-01-10 12:20:00 +0000 |
| commit | 9225033cdf16fd9f3f38b3d3482efb0c36698085 (patch) | |
| tree | b804cf396e2e6b6d4da6082096f933b445671579 /crates/ra_syntax/tests/data/parser/ok/0031_extern.rs | |
| parent | c2b8aa1ce5e5398d981387079e86ff67a5b7e8c0 (diff) | |
| parent | 8384b2cc38acc6e8c1741e8d2d6a66f74b7f02b3 (diff) | |
Merge #477
477: Extend selection for list items r=matklad a=hban
First PR, criticism welcome!
There are a few things I'm not so sure about:
* There is now a not-so-small list of "list-like kinds" in extend selection source which maybe should belong somewhere else.
* Preferring left comma doesn't seem right IMO for one reason - trailing commas are usually on the right. For example, when array values are broken across multiple lines extending selected value will cover right trailing comma (because it's the only comma on the same line), but when all values are on the same line it will pick left comma. Anyway, currently with this PR it will pick always extend to left comma when possible since that's what issue specified 😃.
Closes: #444
Co-authored-by: Hrvoje Ban <[email protected]>
Diffstat (limited to 'crates/ra_syntax/tests/data/parser/ok/0031_extern.rs')
0 files changed, 0 insertions, 0 deletions