aboutsummaryrefslogtreecommitdiff
path: root/crates/rust-analyzer/src/op_queue.rs
diff options
context:
space:
mode:
authorAleksey Kladov <[email protected]>2021-01-10 15:02:02 +0000
committerAleksey Kladov <[email protected]>2021-01-10 15:02:02 +0000
commit2ed258ba423788e95885d43724bb9fc1761cc776 (patch)
treeb4f099cf99710feb2fc6684002813fb8682726c2 /crates/rust-analyzer/src/op_queue.rs
parent77362c71735a8b5ab4b5cd9f396fa657fbffe2cb (diff)
Fix progress token is already registered crash
After we started reporting progress when running cargo check during loading, it is possible to crash the client with two identical progress tokens. This points to a deeper issue: we might be running several cargo checks concurrently, which doesn't make sense. This commit linearizes all workspace fetches, making sure no updates are lost. As an additional touch, it also normalizes progress & result reporting, to make sure they stand in sync.
Diffstat (limited to 'crates/rust-analyzer/src/op_queue.rs')
-rw-r--r--crates/rust-analyzer/src/op_queue.rs25
1 files changed, 25 insertions, 0 deletions
diff --git a/crates/rust-analyzer/src/op_queue.rs b/crates/rust-analyzer/src/op_queue.rs
new file mode 100644
index 000000000..51d66f4b3
--- /dev/null
+++ b/crates/rust-analyzer/src/op_queue.rs
@@ -0,0 +1,25 @@
1//! Bookkeeping to make sure only one long-running operation is executed.
2
3#[derive(Default)]
4pub(crate) struct OpQueue {
5 op_scheduled: bool,
6 op_in_progress: bool,
7}
8
9impl OpQueue {
10 pub(crate) fn request_op(&mut self) {
11 self.op_scheduled = true;
12 }
13 pub(crate) fn should_start_op(&mut self) -> bool {
14 if !self.op_in_progress && self.op_scheduled {
15 self.op_in_progress = true;
16 self.op_scheduled = false;
17 return true;
18 }
19 false
20 }
21 pub(crate) fn op_completed(&mut self) {
22 assert!(self.op_in_progress);
23 self.op_in_progress = false;
24 }
25}