diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-04-19 05:54:04 +0100 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-04-19 05:54:04 +0100 |
| commit | 3f432730dfc7df83fed2d78a97d3d0cf97ffc282 (patch) | |
| tree | 6b284cf75eccc23a2dcaf398767bb939ea5f077e /crates/vfs | |
| parent | 7570212a544b8e973a7d57be3657aae6465028a7 (diff) | |
| parent | 3d1ca786f6355041de9205cadd0a235581dd5af3 (diff) | |
Merge #8467
8467: Adds impl Deref assist r=jhgg a=jhgg
This PR adds a new `generate_deref` assist that automatically generates a deref impl for a given struct field.
Check out this gif:
--
I have a few Q's:
- [x] Should I write more tests, if so, what precisely should I test for?
- [x] I have an inline question on line 65, can someone provide guidance? :)
- [x] I can implement this for `ast::TupleField` too. But should it be a separate assist fn, or should I try and jam both into the `generate_deref`?
- [x] I want to follow this up with an assist on `impl $0Deref for T {` which would automatically generate a `DerefMut` impl that mirrors the Deref as well, however, I could probably use some pointers on how to do that, since I'll have to reach into the ast of `fn deref` to grab the field that it's referencing for the `DerefMut` impl.
Co-authored-by: jake <[email protected]>
Diffstat (limited to 'crates/vfs')
0 files changed, 0 insertions, 0 deletions