diff options
author | Shotaro Yamada <[email protected]> | 2020-02-19 04:29:34 +0000 |
---|---|---|
committer | Shotaro Yamada <[email protected]> | 2020-02-19 04:36:59 +0000 |
commit | d06733efebc5d8b378398f1cbb4bbd9f3deb8270 (patch) | |
tree | 41099b8ebd3f8ca0aea64ac8623e8ac1140ca572 /crates | |
parent | dd0c3c41b927654553fa407fbb654bb3a2c64a48 (diff) |
Cleanup
Diffstat (limited to 'crates')
-rw-r--r-- | crates/ra_assists/src/lib.rs | 2 | ||||
-rw-r--r-- | crates/ra_ide/src/completion/presentation.rs | 6 | ||||
-rw-r--r-- | crates/ra_mbe/src/subtree_source.rs | 2 |
3 files changed, 3 insertions, 7 deletions
diff --git a/crates/ra_assists/src/lib.rs b/crates/ra_assists/src/lib.rs index a0e7fe17e..f4a7497db 100644 --- a/crates/ra_assists/src/lib.rs +++ b/crates/ra_assists/src/lib.rs | |||
@@ -38,7 +38,7 @@ pub struct GroupLabel(pub String); | |||
38 | impl AssistLabel { | 38 | impl AssistLabel { |
39 | pub(crate) fn new(label: String, id: AssistId) -> AssistLabel { | 39 | pub(crate) fn new(label: String, id: AssistId) -> AssistLabel { |
40 | // FIXME: make fields private, so that this invariant can't be broken | 40 | // FIXME: make fields private, so that this invariant can't be broken |
41 | assert!(label.chars().next().unwrap().is_uppercase()); | 41 | assert!(label.starts_with(|c: char| c.is_uppercase())); |
42 | AssistLabel { label, id } | 42 | AssistLabel { label, id } |
43 | } | 43 | } |
44 | } | 44 | } |
diff --git a/crates/ra_ide/src/completion/presentation.rs b/crates/ra_ide/src/completion/presentation.rs index 1a3bcffae..a524987fd 100644 --- a/crates/ra_ide/src/completion/presentation.rs +++ b/crates/ra_ide/src/completion/presentation.rs | |||
@@ -135,11 +135,7 @@ impl Completions { | |||
135 | let (before, after) = (&docs[..idx], &docs[idx + s.len()..]); | 135 | let (before, after) = (&docs[..idx], &docs[idx + s.len()..]); |
136 | // Ensure to match the full word | 136 | // Ensure to match the full word |
137 | if after.starts_with('!') | 137 | if after.starts_with('!') |
138 | && before | 138 | && !before.ends_with(|c: char| c == '_' || c.is_ascii_alphanumeric()) |
139 | .chars() | ||
140 | .rev() | ||
141 | .next() | ||
142 | .map_or(true, |c| c != '_' && !c.is_ascii_alphanumeric()) | ||
143 | { | 139 | { |
144 | // It may have spaces before the braces like `foo! {}` | 140 | // It may have spaces before the braces like `foo! {}` |
145 | match after[1..].chars().find(|&c| !c.is_whitespace()) { | 141 | match after[1..].chars().find(|&c| !c.is_whitespace()) { |
diff --git a/crates/ra_mbe/src/subtree_source.rs b/crates/ra_mbe/src/subtree_source.rs index eb8b79e9a..dacca8279 100644 --- a/crates/ra_mbe/src/subtree_source.rs +++ b/crates/ra_mbe/src/subtree_source.rs | |||
@@ -141,7 +141,7 @@ fn convert_literal(l: &tt::Literal) -> TtToken { | |||
141 | } | 141 | } |
142 | 142 | ||
143 | fn convert_ident(ident: &tt::Ident) -> TtToken { | 143 | fn convert_ident(ident: &tt::Ident) -> TtToken { |
144 | let kind = if let Some('\'') = ident.text.chars().next() { | 144 | let kind = if ident.text.starts_with('\'') { |
145 | LIFETIME | 145 | LIFETIME |
146 | } else { | 146 | } else { |
147 | SyntaxKind::from_keyword(ident.text.as_str()).unwrap_or(IDENT) | 147 | SyntaxKind::from_keyword(ident.text.as_str()).unwrap_or(IDENT) |