diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-10-02 09:07:42 +0100 |
---|---|---|
committer | GitHub <[email protected]> | 2020-10-02 09:07:42 +0100 |
commit | e535489f03901ab94a89dd2de67f35714f0c3cfc (patch) | |
tree | f3e70f9a42b29d3d01448cc298dc61a0bce04294 /crates | |
parent | c3bf7659b13a14541ddcff9c243c79b45bfd6829 (diff) | |
parent | 82d6cfd495c7e0f230ce1ac61e7a4297fa22f02f (diff) |
Merge #6104
6104: Minor clippy performance suggestions r=matklad a=kjeremy
Co-authored-by: kjeremy <[email protected]>
Diffstat (limited to 'crates')
-rw-r--r-- | crates/assists/src/handlers/add_missing_impl_members.rs | 2 | ||||
-rw-r--r-- | crates/assists/src/handlers/extract_struct_from_enum_variant.rs | 2 | ||||
-rw-r--r-- | crates/hir/src/code_model.rs | 2 | ||||
-rw-r--r-- | crates/ide/src/link_rewrite.rs | 4 | ||||
-rw-r--r-- | crates/ssr/src/resolving.rs | 2 | ||||
-rw-r--r-- | crates/syntax/src/ast/edit.rs | 2 |
6 files changed, 7 insertions, 7 deletions
diff --git a/crates/assists/src/handlers/add_missing_impl_members.rs b/crates/assists/src/handlers/add_missing_impl_members.rs index 1ac5fefd6..51b5a2eb0 100644 --- a/crates/assists/src/handlers/add_missing_impl_members.rs +++ b/crates/assists/src/handlers/add_missing_impl_members.rs | |||
@@ -146,7 +146,7 @@ fn add_missing_impl_members_inner( | |||
146 | 146 | ||
147 | let target = impl_def.syntax().text_range(); | 147 | let target = impl_def.syntax().text_range(); |
148 | acc.add(AssistId(assist_id, AssistKind::QuickFix), label, target, |builder| { | 148 | acc.add(AssistId(assist_id, AssistKind::QuickFix), label, target, |builder| { |
149 | let impl_item_list = impl_def.assoc_item_list().unwrap_or(make::assoc_item_list()); | 149 | let impl_item_list = impl_def.assoc_item_list().unwrap_or_else(make::assoc_item_list); |
150 | 150 | ||
151 | let n_existing_items = impl_item_list.assoc_items().count(); | 151 | let n_existing_items = impl_item_list.assoc_items().count(); |
152 | let source_scope = ctx.sema.scope_for_def(trait_); | 152 | let source_scope = ctx.sema.scope_for_def(trait_); |
diff --git a/crates/assists/src/handlers/extract_struct_from_enum_variant.rs b/crates/assists/src/handlers/extract_struct_from_enum_variant.rs index d1eadaa99..f5f03ef36 100644 --- a/crates/assists/src/handlers/extract_struct_from_enum_variant.rs +++ b/crates/assists/src/handlers/extract_struct_from_enum_variant.rs | |||
@@ -91,7 +91,7 @@ fn existing_struct_def(db: &RootDatabase, variant_name: &str, variant: &EnumVari | |||
91 | .module(db) | 91 | .module(db) |
92 | .scope(db, None) | 92 | .scope(db, None) |
93 | .into_iter() | 93 | .into_iter() |
94 | .any(|(name, _)| name.to_string() == variant_name.to_string()) | 94 | .any(|(name, _)| name.to_string() == variant_name) |
95 | } | 95 | } |
96 | 96 | ||
97 | #[allow(dead_code)] | 97 | #[allow(dead_code)] |
diff --git a/crates/hir/src/code_model.rs b/crates/hir/src/code_model.rs index 567fd91af..5721a66c4 100644 --- a/crates/hir/src/code_model.rs +++ b/crates/hir/src/code_model.rs | |||
@@ -145,7 +145,7 @@ impl Crate { | |||
145 | } | 145 | } |
146 | }).flat_map(|t| t).next(); | 146 | }).flat_map(|t| t).next(); |
147 | 147 | ||
148 | doc_url.map(|s| s.trim_matches('"').trim_end_matches("/").to_owned() + "/") | 148 | doc_url.map(|s| s.trim_matches('"').trim_end_matches('/').to_owned() + "/") |
149 | } | 149 | } |
150 | } | 150 | } |
151 | 151 | ||
diff --git a/crates/ide/src/link_rewrite.rs b/crates/ide/src/link_rewrite.rs index 107787bb9..a16f90e17 100644 --- a/crates/ide/src/link_rewrite.rs +++ b/crates/ide/src/link_rewrite.rs | |||
@@ -120,7 +120,7 @@ fn rewrite_intra_doc_link( | |||
120 | 120 | ||
121 | /// Try to resolve path to local documentation via path-based links (i.e. `../gateway/struct.Shard.html`). | 121 | /// Try to resolve path to local documentation via path-based links (i.e. `../gateway/struct.Shard.html`). |
122 | fn rewrite_url_link(db: &RootDatabase, def: ModuleDef, target: &str) -> Option<String> { | 122 | fn rewrite_url_link(db: &RootDatabase, def: ModuleDef, target: &str) -> Option<String> { |
123 | if !(target.contains("#") || target.contains(".html")) { | 123 | if !(target.contains('#') || target.contains(".html")) { |
124 | return None; | 124 | return None; |
125 | } | 125 | } |
126 | 126 | ||
@@ -190,7 +190,7 @@ fn strip_prefixes_suffixes(mut s: &str) -> &str { | |||
190 | prefixes.clone().for_each(|prefix| s = s.trim_start_matches(*prefix)); | 190 | prefixes.clone().for_each(|prefix| s = s.trim_start_matches(*prefix)); |
191 | suffixes.clone().for_each(|suffix| s = s.trim_end_matches(*suffix)); | 191 | suffixes.clone().for_each(|suffix| s = s.trim_end_matches(*suffix)); |
192 | }); | 192 | }); |
193 | s.trim_start_matches("@").trim() | 193 | s.trim_start_matches('@').trim() |
194 | } | 194 | } |
195 | 195 | ||
196 | static TYPES: ([&str; 7], [&str; 0]) = | 196 | static TYPES: ([&str; 7], [&str; 0]) = |
diff --git a/crates/ssr/src/resolving.rs b/crates/ssr/src/resolving.rs index 5d2cbec47..347cc4aad 100644 --- a/crates/ssr/src/resolving.rs +++ b/crates/ssr/src/resolving.rs | |||
@@ -205,7 +205,7 @@ impl<'db> ResolutionScope<'db> { | |||
205 | 205 | ||
206 | /// Returns the function in which SSR was invoked, if any. | 206 | /// Returns the function in which SSR was invoked, if any. |
207 | pub(crate) fn current_function(&self) -> Option<SyntaxNode> { | 207 | pub(crate) fn current_function(&self) -> Option<SyntaxNode> { |
208 | self.node.ancestors().find(|node| node.kind() == SyntaxKind::FN).map(|node| node.clone()) | 208 | self.node.ancestors().find(|node| node.kind() == SyntaxKind::FN) |
209 | } | 209 | } |
210 | 210 | ||
211 | fn resolve_path(&self, path: &ast::Path) -> Option<hir::PathResolution> { | 211 | fn resolve_path(&self, path: &ast::Path) -> Option<hir::PathResolution> { |
diff --git a/crates/syntax/src/ast/edit.rs b/crates/syntax/src/ast/edit.rs index dda0a0319..77233ab31 100644 --- a/crates/syntax/src/ast/edit.rs +++ b/crates/syntax/src/ast/edit.rs | |||
@@ -159,7 +159,7 @@ impl ast::AssocItemList { | |||
159 | let whitespace = | 159 | let whitespace = |
160 | last_token_before_curly.clone().into_token().and_then(ast::Whitespace::cast)?; | 160 | last_token_before_curly.clone().into_token().and_then(ast::Whitespace::cast)?; |
161 | let text = whitespace.syntax().text(); | 161 | let text = whitespace.syntax().text(); |
162 | let newline = text.rfind("\n")?; | 162 | let newline = text.rfind('\n')?; |
163 | let keep = tokens::WsBuilder::new(&text[newline..]); | 163 | let keep = tokens::WsBuilder::new(&text[newline..]); |
164 | Some(self.replace_children( | 164 | Some(self.replace_children( |
165 | first_token_after_items..=last_token_before_curly, | 165 | first_token_after_items..=last_token_before_curly, |