diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-01-01 11:06:27 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-01-01 11:06:27 +0000 |
| commit | 51d29fe55456e6e7af69d23982aa57c7fcf91e81 (patch) | |
| tree | 0deaf9b05ac36cf7ca34d632621f5d99aa94e793 /docs/dev/debugging.md | |
| parent | ff0c976979ad236e725a808fd2dba5e41ff4eace (diff) | |
| parent | ae92baba6a3f70a5234dc4fcf15660c2c01deeee (diff) | |
Merge #7116
7116: Fix deep syntax tree bug generated by proc-macro r=jonas-schievink a=edwin0cheng
This PR fixed a bug from `semver-parser` and `pest_derive` crates which generate a very deep syntax tree such that serde reject to de-serialize. To fix this bug, we disabled recursion limit in `serde` (by calling [`Deserializer::disable_recursion_limit`](https://docs.rs/serde_json/1.0.61/serde_json/struct.Deserializer.html#method.disable_recursion_limit))
I have a feeling that we still need some way to protect against bad proc-macro generating huge syntax node, but I have no idea right now.
r? @jonas-schievink
Fixes #7103
Co-authored-by: Edwin Cheng <[email protected]>
Diffstat (limited to 'docs/dev/debugging.md')
0 files changed, 0 insertions, 0 deletions