diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-01-06 21:25:13 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2020-01-06 21:25:13 +0000 |
| commit | c92a090f49cad2fa540562536f07fcb619f16680 (patch) | |
| tree | 6a28cc8aa0172f54b0a0e659b9f45eca7aac7f91 /docs/dev/guide.md | |
| parent | 07340a62cc1b34efcebfc9f4cfc42f655edd2fc8 (diff) | |
| parent | be967b94e15f238a6fe806e93359e302c43d0e45 (diff) | |
Merge #2753
2753: Fix a problem with `Durability` of libraries r=matklad a=michalt
When processing a change with added libraries, we used
`Default::default` for `SourceRoot` which sets `is_library` to false.
Since we use `is_library` to decide whether to use low or high
durability, I believe that this caused us to mark many library
dependencies as having low durability and thus increased the size of the
graph that salsa needed to verify on every change.
Based on my initial tests this speeds up the `CrateDefMapQuery` on
rust-analyzer from about ~64ms to ~14ms and reduces the number of
validations for the query from over 60k to about 7k.
Signed-off-by: Michal Terepeta <[email protected]>
Co-authored-by: Michal Terepeta <[email protected]>
Diffstat (limited to 'docs/dev/guide.md')
0 files changed, 0 insertions, 0 deletions