aboutsummaryrefslogtreecommitdiff
path: root/docs/dev/lsp-features.md
diff options
context:
space:
mode:
authorbors[bot] <26634292+bors[bot]@users.noreply.github.com>2020-04-24 21:10:54 +0100
committerGitHub <[email protected]>2020-04-24 21:10:54 +0100
commit51a0058d4c01ca8a64066528f82aa4bb7cc4fc54 (patch)
treeb20a5fcfcb8980dd0228c72d79f31761ba6e84e7 /docs/dev/lsp-features.md
parente55b1833ffe896179d9d97ebec9caaf9256e0616 (diff)
parentf2f882bc44a85eb13276a8fbda7533d94e92e3af (diff)
parent445052f6d426043b543033f3fa4594fc1a09d7fa (diff)
Merge #3998 #4006
3998: Make add_function generate functions in other modules via qualified path r=matklad a=TimoFreiberg Additional feature for #3639 - [x] Add tests for paths with more segments - [x] Make generating the function in another file work - [x] Add `pub` or `pub(crate)` to the generated function if it's generated in a different module - [x] Make the assist jump to the edited file - [x] Enable file support in the `check_assist` helper 4006: Syntax highlighting for format strings r=matklad a=ltentrup I have an implementation for syntax highlighting for format string modifiers `{}`. The first commit refactors the changes in #3826 into a separate struct. The second commit implements the highlighting: first we check in a macro call whether the macro is a format macro from `std`. In this case, we remember the format string node. If we encounter this node during syntax highlighting, we check for the format modifiers `{}` using regular expressions. There are a few places which I am not quite sure: - Is the way I extract the macro names correct? - Is the `HighlightTag::Attribute` suitable for highlighting the `{}`? Let me know what you think, any feedback is welcome! Co-authored-by: Timo Freiberg <[email protected]> Co-authored-by: Leander Tentrup <[email protected]> Co-authored-by: Leander Tentrup <[email protected]>