diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-06-23 15:55:03 +0100 |
---|---|---|
committer | GitHub <[email protected]> | 2020-06-23 15:55:03 +0100 |
commit | c0b9ae55034fd29a86f52822634fcb1c1303e7f9 (patch) | |
tree | 4a97c8939ae27fa3c3f30fa46729383a71b810e7 /docs/dev | |
parent | 3e09dbba94de103d4d7a211ec578b049d0adc3c7 (diff) | |
parent | 76ddface089886c88b8b29e3893119f38ef26aab (diff) |
Merge #5004
5004: Fix panic in split/merge import assists r=matklad a=lnicola
Fixes #4368 #4905
Not sure if this is the best solution here. Maybe the `make` functions should be fallible? We generally seem to be playing whack-a-mole with panics in assists, although most of them are `unwrap`s in the assist code.
Co-authored-by: Laurențiu Nicola <[email protected]>
Diffstat (limited to 'docs/dev')
-rw-r--r-- | docs/dev/README.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/docs/dev/README.md b/docs/dev/README.md index 1b63d8223..76e1da6cf 100644 --- a/docs/dev/README.md +++ b/docs/dev/README.md | |||
@@ -348,6 +348,8 @@ To update test data, run with `UPDATE_EXPECTATIONS` variable: | |||
348 | env UPDATE_EXPECTATIONS=1 cargo qt | 348 | env UPDATE_EXPECTATIONS=1 cargo qt |
349 | ``` | 349 | ``` |
350 | 350 | ||
351 | After adding a new inline test you need to run `cargo xtest codegen` and also update the test data as described above. | ||
352 | |||
351 | # Logging | 353 | # Logging |
352 | 354 | ||
353 | Logging is done by both rust-analyzer and VS Code, so it might be tricky to | 355 | Logging is done by both rust-analyzer and VS Code, so it might be tricky to |