diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2020-06-08 12:20:01 +0100 |
---|---|---|
committer | GitHub <[email protected]> | 2020-06-08 12:20:01 +0100 |
commit | a5f427ced3ee0ec27041f0b7632b4baae6a736b2 (patch) | |
tree | 8c701f08d3b99c5be7445b2f0389c2d1a8d2692c /docs | |
parent | 3623c1663f9135504c943c44212e99e5198b16a5 (diff) | |
parent | 4968321706fc5c24d9f2c35cdbbd5e9047c97c96 (diff) |
Merge #4793
4793: Don't @ people in commit messages r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <[email protected]>
Diffstat (limited to 'docs')
-rw-r--r-- | docs/dev/README.md | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/docs/dev/README.md b/docs/dev/README.md index 5a9c0a148..46ee030fc 100644 --- a/docs/dev/README.md +++ b/docs/dev/README.md | |||
@@ -261,6 +261,14 @@ fn frobnicate(walrus: Option<Walrus>) { | |||
261 | } | 261 | } |
262 | ``` | 262 | ``` |
263 | 263 | ||
264 | ## Commit Style | ||
265 | |||
266 | We don't have specific rules around git history hygiene. | ||
267 | Maintaining clean git history is encouraged, but not enforced. | ||
268 | We use rebase workflow, it's OK to rewrite history during PR review process. | ||
269 | |||
270 | Avoid @mentioning people in commit messages, as such messages create a lot of duplicate notification traffic during rebases. | ||
271 | |||
264 | # Architecture Invariants | 272 | # Architecture Invariants |
265 | 273 | ||
266 | This section tries to document high-level design constraints, which are not | 274 | This section tries to document high-level design constraints, which are not |